Re: [PATCH] Shortcode detection in smsc_smpp.c (1.4.3 based)

On Mon, Mar 2, 2009 at 10:10 AM, Slavoj Hruška <[email protected]> wrote:
> Hi,
>
> at first sorry about my poor english ;) I hope that my patch will be better
> ;)
>
> Description:
>
> problematic setup:
>
> source-addr-autodetect = yes
> dest-addr-ton = 1
> dest-addr-npi = 1
> source-addr-ton = 1
> source-addr-npi = 1
>
> Testcase 1)
>
> FROM = 421xxxYYYYYY (international formated)
>  TO = 420xxxYYYYYY (international formated)
>
> result = OK
>
>
> Testcase 2)
>
> FROM = SANTA        (Alphanumeric sender)
>  TO = 420xxxYYYYYY (international formated)
>
> result = OK
>
>
>
> Testcase 3)
>
> FROM = 12345        (shortcode)
>  TO = 420xxxYYYYYY (international formated)
>
> result = PROBLEM
> MT show sender as +12345 and SMS can not be replyed.
>
> After that patch everything is ok.
>
> I hope that my "SHORTCODE ENGLISH" explanation was clear to clear purpose
> of that patch ;)
>
> PS: Stipe, thnx for "howto"
>
> --
>
> --
> S pozdravom / Sincerely Yours
>
> Slavoj Hruska
> Director

Hello,

-1 Here

1) You are setting ton/npi to 1
2) This patch isn't against CSV HEAD.
3) Santa's way?

Regards,
M