Re: [PATCH] Shortcode detection in smsc_smpp.c (1.4.3 based)

Am 02.03.2009 um 14:24 schrieb Slavoj Hruška:

> Hi,
>
> technicaly u are right. But if it's autodetect, it should detect it,  
> or
> nope ?

kannel detects all the cases...

>
> In my case i can not use your suggestion (it is working and known)  
> coz all
> systems
> uppon kannel are sending numbers withouth leading PLUS sign.

this is just up to you, how you internal systems working. BUT kannel  
expects to see
+ in front that is indicate a international number. If your  
applications doesn't respect it,
then which fault it should be? 100% not kannel's ;)

>
>
> I do not know, why do not detect known source addr type if we can.  
> There is
> nowhere written that when src ton and npi are seted to one, only  
> thing that
> autodetect can detect is difference between alphanumeric or  
> international
> sender id.
>
> When ton and npi are 0, there is "full detect mode" with "shortcode"
> detection too. So why to discriminate oposite "default" situation.
>
>
> I know, that's may be not well writen patch for performance look,  
> but it
> can be rewriten to have less "ticks" to execute.

rejection is not because of performance, it's because your patch just  
wrong... we have already
this functionality in place and working, why do we need this patch if  
it just works now?
Fix your applications and it will work as expected...

>
>
> S.
>
> On Mon, 2 Mar 2009 14:12:05 +0100, Alexander Malysh <[email protected] 
> >
> wrote:
>> Hi,
>>
>> -1 for this patch because it's just misconfiguration at your side.
>>
>> Try to remove all of these from your smsc group:
>>> source-addr-autodetect = yes
>>> dest-addr-ton = 1
>>> dest-addr-npi = 1
>>> source-addr-ton = 1
>>> source-addr-npi = 1
>>
>> and sent sms with shortcode as sender and you will see that it works
>> as expected.
>> for the testcase (1) you should send as +421XXXXX and kannel will
>> autodetect international numberplan and set it.
>>
>> Thanks,
>> Alex
>>
>>
>> Am 02.03.2009 um 13:10 schrieb Slavoj Hruška:
>>
>>> Hi,
>>>
>>> at first sorry about my poor english ;) I hope that my patch will be
>>> better
>>> ;)
>>>
>>> Description:
>>>
>>> problematic setup:
>>>
>>> source-addr-autodetect = yes
>>> dest-addr-ton = 1
>>> dest-addr-npi = 1
>>> source-addr-ton = 1
>>> source-addr-npi = 1
>>>
>>> Testcase 1)
>>>
>>> FROM = 421xxxYYYYYY (international formated)
>>> TO = 420xxxYYYYYY (international formated)
>>>
>>> result = OK
>>>
>>>
>>> Testcase 2)
>>>
>>> FROM = SANTA        (Alphanumeric sender)
>>> TO = 420xxxYYYYYY (international formated)
>>>
>>> result = OK
>>>
>>>
>>>
>>> Testcase 3)
>>>
>>> FROM = 12345        (shortcode)
>>> TO = 420xxxYYYYYY (international formated)
>>>
>>> result = PROBLEM
>>> MT show sender as +12345 and SMS can not be replyed.
>>>
>>> After that patch everything is ok.
>>>
>>> I hope that my "SHORTCODE ENGLISH" explanation was clear to clear
>>> purpose
>>> of that patch ;)
>>>
>>> PS: Stipe, thnx for "howto"
>>>
>>> -- 
>>>
>>>
> -- 
>
> -- 
> S pozdravom / Sincerely Yours
>
> Slavoj Hruska
> Director
>
> SMS-Brana.SK
> ------------------------------------
> Tel. (SK) : +421-47-2250119
> Tel. (UK) : +44-203-1296148
> Tel. (USA): +1-235-397-1823
> Tel. (SK) : +421-650-822969 - HaVel VoIP
> Fax. (SK) : +421-2-20252478
>
> E-Mail    : [email protected]
> WEB       : http://www.sms-brana.sk/
> ------------------------------------
>
> XEN-Housing s.r.o.
> Panenská 24
> 811 09 Bratislava
>
> IČO: 44 010 567
> DIČ: 2022556030
> Registrácia: Okresný súd Bratislava I, odd.: Sro, vl.č.: 51050/B
>
>