Re: [PATCH] BUG on DLR parsing

To ellaborate further:

Before the patch:

2009-04-29 10:27:35 Receive DLR [SMSC:mysmsc] [SVC:kannel] [ACT:]  
[BINF:] [FID:6c94507e] [META:?smpp?] [from:12345] [to:12345678901]  
[flags:-1:-1:-1:-1:2] [msg:112:id:1821659262 sub:001 dlvrd:000 submit  
date:0904290727 done date:0904290727 stat:UNDELIV err:401  
text:DlrTesting] [udh:0:]

After the patch:

2009-04-29 11:52:26 Receive DLR [SMSC:mysmsc] [SVC:kannel] [ACT:]  
[BINF:401] [FID:6c94907e] [META:?smpp?] [from:12345] [to:12345678901]  
[flags:-1:-1:-1:-1:2] [msg:112:id:1821675646 sub:001 dlvrd:000 submit  
date:0904290852 done date:0904290852 stat:UNDELIV err:401  
text:DlrTesting] [udh:0:]

Regards,
--
Alejandro Guerrieri
[email protected]



On 29/04/2009, at 18:10, Alejandro Guerrieri wrote:

> This patch fixes a bug when parsing DLR's:
>
> As the code is now, if a DLR having a receipted_message_id, the DLR  
> text is not parsed, so the "err" and "stat" fields are empty.
>
> In particular, the "err" code is being passed on the "binfo" field,  
> so this remained empty if a receipted_message_id is present (because  
> the sscanf code was not executed).
>
> Attached patch fixes that part, so the "err" parameter is present on  
> the binfo field on all cases.
>
> Regards,
> --
> Alejandro Guerrieri
> [email protected]
>
>
> <kannel-smsc-dlr-err.patch>
>