Re: [PATCH] BUG on DLR parsing
Alejandro Guerrieri <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <[email protected]> |
Well, I've grabbed that part from the code already there, and that was the way it was done (I've just fixed the bug when a receipted_message_id was present). On the other hand, I agree overloading binfo with random stuff is far from ideal. Regards, -- Alejandro Guerrieri [email protected] On 30/04/2009, at 9:30, Alexander Malysh wrote: > Hi, > > I don't like passing err in binfo field. IMO binfo should be used > for billing identifier but not for smpp error code. > I would prefer to see patch that drop err from binfo and make use of > meta-data (group dlr?). > > Thanks, > Alex > > Am 29.04.2009 um 18:10 schrieb Alejandro Guerrieri: > >> This patch fixes a bug when parsing DLR's: >> >> As the code is now, if a DLR having a receipted_message_id, the DLR >> text is not parsed, so the "err" and "stat" fields are empty. >> >> In particular, the "err" code is being passed on the "binfo" field, >> so this remained empty if a receipted_message_id is present >> (because the sscanf code was not executed). >> >> Attached patch fixes that part, so the "err" parameter is present >> on the binfo field on all cases. >> >> Regards, >> -- >> Alejandro Guerrieri >> [email protected] >> >> >> <kannel-smsc-dlr-err.patch> >> >