Question about dlr_add and dlr_find parameters

Alejandro Guerrieri <[email protected]>
Newsgroups gmane.comp.mobile.kannel.devel
Message-ID <[email protected]>
Hi,

Just a quick question: I'm checking on different smsc's  
implementations and I've noticed that, despite that dlr_add and  
dlr_find are usually called using conn->id for the first parameter  
(smsc), on some smsc's conn->name is used instead:

gw/smsc/smsc_cimd2.c:	dlr_add(conn->name, ts, msg);
gw/smsc/smsc_emi.c:		dlr_add((conn->id ? conn->id : privdata->name),  
ts, m);
gw/smsc/smsc_oisd.c:	dlr_add(conn->name, ts, msg);

Does anybody know if is there any reason for this or is it just a  
different implementation?

Would it make any sense to change it to be in line with the rest?

I guess it makes sense to use conn->id since it's user-definable,  
though conn->name is generated from the connection parameters (host,  
port, user), though limiting what can be done with it (for example:  
two different binds wouldn't be able to manage dlr's from each other).

Regards,
--
Alejandro Guerrieri
[email protected]
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.