Re: [PATCH] Intermediate Notification support for SMPP

Hi Alex,

I'm +0 for this patch as such because never used intermediate DLRs.

As to the patch itself:
1) please fix indents (as usual...)
2) DLR_ASK_INTERMEDIATE(dlr) -> DLR_IS_INTERMEDIATE (this is our  
naming schema)

Otherwise patch looks trivial. The only questions is, whether we want  
support intermediate DLRs?

Thanks,
Alex


Am 15.05.2009 um 00:29 schrieb Alejandro Guerrieri:

> Hi,
>
> This patch adds support for intermediate notification DLR's on SMPP.
>
> According to the SMPP 3.4 spec. section 5.2.17, Intermediate  
> Notifications are enabled by setting the bit 5 (0x10) on the  
> registered_delivery flag. To do this (after applying this patch),  
> you must add 32 to the dlr-mask and it will set the bit on the  
> submit_sm PDU's.
>
> The patch also fixes a small glitch on the sscanf dlr parsing. On my  
> tests with a major carrier on the US, it turned out that the value  
> for the "err:" field could be hex-encoded (Alex: I know I shouldn't  
> mix stuff, but this one was just a line: @@ -1269,7 +1272,7 @@)
>
> I'm writing the userguide docs if this is accepted, as usual ;)
>
> Regards,
> --
> Alejandro Guerrieri
> [email protected]
>
> <kannel-dlr-intermediate.patch>