Re: [PATCH] Intermediate Notification support for SMPP

Yeah, I agree, there's no way to comply with 'proper' indentation when  
the file is already messed up.

Perhaps doing it little by little to be sure that nothing's broken in  
the process?

I'm definitely doing it on sqlbox.

Regards,
--
Alejandro Guerrieri
[email protected]



On 16/05/2009, at 0:13, Martin Conte Mac Donell wrote:

> On Fri, May 15, 2009 at 6:16 AM, Alejandro Guerrieri
> <[email protected]> wrote:
>> I've used all spaces before, I'm not sure what's the proper way  
>> here, my new
>> patch uses the same approach as it's neighboring lines, though it's  
>> not
>> consistent across the file.
>> Regards,
>
> I made a BIG patch once changing every tab for 4 spaces and fixing
> every indentation issue.
>
> Of course it was very hard to review (Although i suggested to check
> old vs new version using diff ignoring spaces changes).
>
> Sometime, somewhere, at some point, should change tabs to spaces or
> vice versa(to avoid flame wars) in kannel code.
>
> M.