Re: [PATCH] account parameter for MO/DLR, non intrusive

Hi,

just curios why this should be needed? is not enough to have smscid?

Thanks,
Alex

Am 03.06.2009 um 12:56 schrieb Stipe Tolj:

> Hi list,
>
> first of all, my apologies for being so quite a long time. I'll try  
> to grep some
> road on the devel@ list at least and keep track.
>
> Here is a very simple patch, a two liner, literally. It simply  
> ensures that the
> SMPP username is duplicated to the msg->sms.account variable for MO  
> and DLR
> messages. Currently we don't populate this one. And we want to  
> preserve the same
> "semantics/logic" for the MO direction case here as for the MT case.
>
> It allows to use the '%o' escape code in a sms-service group i.e. to  
> pass the
> used SMPP account username.
>
> If no objections apply, I'll commit shortly.
>
> Thanks,
> Stipe
>
> -- 
> -------------------------------------------------------------------
> Kölner Landstrasse 419
> 40589 Düsseldorf, NRW, Germany
>
> tolj.org system architecture      Kannel Software Foundation (KSF)
> http://www.tolj.org/              http://www.kannel.org/
>
> mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
> -------------------------------------------------------------------
> ### Eclipse Workspace Patch 1.0
> #P gateway-cvs-head
> Index: gw/smsc/smsc_smpp.c
> ===================================================================
> RCS file: /home/cvs/gateway/gw/smsc/smsc_smpp.c,v
> retrieving revision 1.117
> diff -u -r1.117 smsc_smpp.c
> --- gw/smsc/smsc_smpp.c	20 May 2009 10:16:25 -0000	1.117
> +++ gw/smsc/smsc_smpp.c	2 Jun 2009 11:47:45 -0000
> @@ -1348,6 +1348,7 @@
>          */
>         dlrmsg->sms.msgdata = octstr_duplicate(respstr);
>         dlrmsg->sms.sms_type = report_mo;
> +        dlrmsg->sms.account = octstr_duplicate(smpp->username);
>         if (err != NULL) {
>             if (dlrmsg->sms.meta_data == NULL) {
>                 dlrmsg->sms.meta_data = octstr_create("");
> @@ -1502,6 +1503,7 @@
>
>                 time(&msg->sms.time);
>                 msg->sms.smsc_id = octstr_duplicate(smpp->conn->id);
> +                msg->sms.account = octstr_duplicate(smpp->username);
>                 reason =  bb_smscconn_receive(smpp->conn, msg);
>                 resp->u.deliver_sm_resp.command_status =  
> smscconn_failure_reason_to_smpp_status(reason);
>             }