Re: [PATCH] smsc_at2.c error string

This is already as it.

error(0, "AT2[%s]: +CMS ERROR: %s (%d)", octstr_get_cstr(privdata->name), at2_error_string(errcode), errcode);

Vincent.


Alvaro Cornejo a écrit :
> Hi Vincent
> 
> Might it be possible to show the message error number/code in the
> error message text? This way it will be easyer to google for
> additional information.
> 
> someting like:
> 
> 
>      case 0:
>          /*
>           * Station cannot be reached because, although the number is in a
>           * valid format, it is not currently assigned (allocated).
>           */
>         return "[0] Unassigned (unallocated) number (+CMS) or No
> connection to phone (+CME)";
>     case 2:
>         return "[2] Phone-adaptor link reserved";
>      case 3:
>          /*
>           * This can be a lot of things, depending upon the command,
> but in general
>           * it relates to invaid parameters being passed.
>           */
>          return "[3] Operation / Parameter(s) not supported";
>     case 5:
>         return "[5] PH-SIM PIN required";
> ...
> 
>      default:
>         return "[code] Error number unknown. Ask google and add it";
> 
> This will also help people parse the logs
> 
> Regards
> 
> Alvaro
> 
>