Re: [PATCH] http admin commands
"Nikos Balkanas" <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <001601c9fee8$802dc200$02b2a8c0@tardis> |
Sorely needed. Good job! +1 Nikos ----- Original Message ----- From: Alejandro Guerrieri To: Kannel Devel Sent: Tuesday, July 07, 2009 9:14 AM Subject: [PATCH] http admin commands This patch improves the http-based admin commands and fixes some quirks: 1. It adds 2 new commands: add-smsc and remove-smsc that allows for dynamic adding/removing of smsc's without restarting kannel nor any other smsc bind. 2. start-smsc now reloads the smsc list from the config file, so you can stop-smsc and then start-smsc to reload the configuration. The only caveat is: do not change the id or admin-id (in that case you'll have to remove-smsc with the old id/admin-id and add-smsc with the new one instead). 3. Fixes a bug on stop-smsc and start-smsc. Before, you could start/stop non-existant smsc's, and despite the request would be ignored, the interface would say that the smsc was stopped/started. Now it will return an error and log the reason. 4. Fixes a bug on the id/admin-id functionality when stopping/starting a group with 2 or more entries with the same id and different admin-id's. Before, the list would get corrupted when trying to start again, now it works as expected. Userguide patch coming soon :) Please review in the meantime. Regards, -- Alejandro Guerrieri [email protected] ------------------------------------------------------------------------------ ------------------------------------------------------------------------------ This patch improves the http-based admin commands and fixes some quirks: 1. It adds 2 new commands: add-smsc and remove-smsc that allows for dynamic adding/removing of smsc's without restarting kannel nor any other smsc bind. 2. start-smsc now reloads the smsc list from the config file, so you can stop-smsc and then start-smsc to reload the configuration. The only caveat is: do not change the id or admin-id (in that case you'll have to remove-smsc with the old id/admin-id and add-smsc with the new one instead). 3. Fixes a bug on stop-smsc and start-smsc. Before, you could start/ stop non-existant smsc's, and despite the request would be ignored, the interface would say that the smsc was stopped/started. Now it will return an error and log the reason. 4. Fixes a bug on the id/admin-id functionality when stopping/starting a group with 2 or more entries with the same id and different admin- id's. Before, the list would get corrupted when trying to start again, now it works as expected. Userguide patch coming soon :) Please review in the meantime. Regards, -- Alejandro Guerrieri [email protected]