dlr_sdb fixes (?)

Thanos Chatziathanassiou <[email protected]>
Newsgroups gmane.comp.mobile.kannel.devel
Message-ID <[email protected]>
I noticed that some commit to CVS after 1.4.3 incorporated checking like 
this in dlr_sdb.c:

     if (state == -1)
         error(0, "SDB: error in inserting DLR for DST <%s>", 
octstr_get_cstr(dlr->destination));
     else if (!state)
         warning(0, "SDB: No dlr inserted for DST <%s>", 
octstr_get_cstr(dlr->destination));

The -1 part is obviously sane, however it is perfectly legal for sdb to 
return 0 for a number of actions, depending on the back-end database, 
e.g. INSERT, UPDATE and DELETE to sqlite return 0 even though the 
operation does complete successfully.
The warning message is a little ominous and not explanatory at all.
I don't have any other database to check against right now, but would we 
mind altering the message/lowering the severity a little ?

Best Regards,
Thanos Chatziathanassiou
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.