Re: Limit SMS Sending Retries/Handshake Error Patch

Alexander Malysh <[email protected]>
Newsgroups gmane.comp.mobile.kannel.devel
Message-ID <[email protected]>
Hi,

Am 02.04.2010 um 16:12 schrieb hisham malik:

> Attaching more patches for the kannel source. 
> 
> 1. Limit SMS Sending Retries:
> Limit SMS sending retries in split/long messages

this is not a proper fix because you end to failing the whole multipart message if one part can't be send
e.g. due to the throttling error and this patch doesn't handle resend via the same SMSC.

> 
> 2. Handshake Error and Garbage Character in Long Message:
> Added send_failed call to the message sending function when error is received during handshake.
> Fixed garbage characters in multi-part messages. 

This patch is partially commited. I don't understand part about garbage chars. Could you please explain in details
why we need this patch? If we need this patch then len calculation is somewhere broken.

Please don't use // as comment because it not valid C and if you make patches please make it with ignore white spaces
because it's very hard to read...

Thanks,
Alexander Malysh
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.