Re: [PATCH] msg storage abstraction to instances

Hi Stipe,

I don't see any abstraction with this patch. Only one thing is allowed with this patch: define more as one
msg store for one process.

From abstraction patch I would expect something like:

- gwlib/store_[spool|file] that has pointer to pack and unpack some data void* 
- gw/msg_store that make use of the above

Msg* doesn't belongs to gwlib as you made it in your patch. Msg* is gateway internals and not gwlib.

Thanks,
Alexander Malysh

Am 01.03.2010 um 12:46 schrieb Stipe Tolj:

> Hi list,
> 
> I have attached a patch against CVS HEAD, that abstracts our current code in
> 
>  gw/bb_store.[ch]
>  gw/bb_store_[file|spool].c
> 
> to allow INSTANTIATION of a message storage by a context handler. I moved the
> code to
> 
>  gwlib/msg_store[_p].[ch]
>  gwlib/msg_store_[file|spool].c
> 
> and changed the store_foobar(...) references to msg_store_foobar(msg_store,...)
> in the bearerbox specific files
> 
>  gw/bb_[boxc|http|smsconn].c
>  gw/bearerbox.[ch]
> 
> to comply with the existing behavior. Hence the patch is a NLC (no logic
> change), but allows using several message storage instances/contexts in any daemon.
> 
> Example: We could implement a SQL msg storage implementation
> (gwlib/msg_store_mysql.c) or on the "other" side, implement a DLR storage type
> of a msg store. (gw/dlr_msg_store.c).
> 
> Kindly have a look and vote for commitment. If there are no objections to have
> the message storage more abstracted this way, I will commit the code and remove
> the "old" static module approach.
> 
> Stipe
> 
> -- 
> -------------------------------------------------------------------
> Kölner Landstrasse 419
> 40589 Düsseldorf, NRW, Germany
> 
> tolj.org system architecture      Kannel Software Foundation (KSF)
> http://www.tolj.org/              http://www.kannel.org/
> 
> mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org