Re: Simple patch to allow OISD to handle empty MO messages

Alexander Malysh <[email protected]>
Newsgroups gmane.comp.mobile.kannel.devel
Message-ID <[email protected]>
Hi Michael,

patch commited to SVN. Thanks!

Thanks,
Alexander Malysh

Am 27.05.2010 um 17:54 schrieb Michael Zervakis:

> Dear all,
> 
>   Kannel implementation of OISD will discard empty mobile originated sms. I think this is not acceptable in most cases. This simple patch should fix this.
> 
> BR,
> 
> Michael Zervakis
> Index: smsc_oisd.c
> ===================================================================
> --- smsc_oisd.c	(revision 4831)
> +++ smsc_oisd.c	(working copy)
> @@ -894,9 +894,7 @@
> 
>     if ((!(msg->sms.msgdata) || octstr_len(msg->sms.msgdata) == 0)
>         && (!(msg->sms.udhdata) || octstr_len(msg->sms.udhdata) == 0)) {
> -        info(0, "OISD[%s]: Got empty SMS, ignoring.",
> -              octstr_get_cstr(conn->id));
> -        goto error;
> +        msg->sms.msgdata = octstr_create("");		
>     }
> 
>     return msg;
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.