Re: Patch: test/drive_smpp.c

If styling rules are one man's decision, better be acceptable and to a 
degree flexible, or they will deter contributors from submitting work. Which 
contradicts open source philosophy. Granted  kannel is in better shape than 
most other software, but there is always room for improvement.

BR,
Nikos
----- Original Message ----- 
From: "Milan P. Stanic" <[email protected]>
To: <[email protected]>
Sent: Sunday, July 04, 2010 12:52 PM
Subject: Re: Patch: test/drive_smpp.c


> On Sun, 2010-07-04 at 00:58, Nikos Balkanas wrote:
>> I am very sorry. My apologies for the missunderstanding. My
>> impression is that identation means replacing tabs with spaces and
>> aligning left text according to level. I see here that you are
>> actually asking about source code reformatting and even for a code
>> change. Some of the styling options that you ask, especially that
>> "if" statement, are unreadable by several people, including me.
>> Well, not exactly unreadable, but very difficult to read. And that
>> is a problem in the case of the author who is called to support it.
>> Who decided on this style anyway?
>
> In the free/open source software usually maintainers are those who set
> the rules and style.
>
> [ And usually (as is the case in kannel) these rules and style are far
>  better than in commercial software ]
>
> -- 
> Kind regards,  Milan
> --------------------------------------------------
> Arvanta,         http://www.arvanta.net
> Please do not send me e-mail containing HTML code.
>