Re: [PATCH] smppbox :: ton/npi configuration
Victor Luchitz <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <[email protected]> |
Well, smppbox defaulted these to 0, so I figured it was done on purpose :) Anyway, it's enough to initialize the corresponding static vars to -1 as cfg_get_integer doesn't change value of a var it didn't find. 2010/7/9 Rene Kluwen <[email protected]>: > Sorry for the triple post. > > Default value should be -1. So ton/npi will be inherited from the smpp pdu. > Only needed if you want to manually force these values. > > == Rene > > -----Original Message----- > From: [email protected] [mailto:[email protected]] On Behalf Of Rene Kluwen > Sent: vrijdag 9 juli 2010 21:12 > To: 'Victor Luchitz'; [email protected] > Subject: RE: [PATCH] smppbox :: ton/npi configuration > > Also there should be a default ton/npi (possibly 0) in case it is not specified in the configuration file. > > -----Original Message----- > From: [email protected] [mailto:[email protected]] On Behalf Of Victor Luchitz > Sent: vrijdag 9 juli 2010 20:39 > To: [email protected] > Subject: [PATCH] smppbox :: ton/npi configuration > > Hello! > > Please consider merging the patch attached, which makes ton and npi for both source and destination configurable - using 0 for both by default isn't the best of options in my opinion. Thanks in advance. > > -- > Best regards, > Victor Luchitz > > > > > -- Best regards, Victor Luchitz