Re: [PATCH] Smppbox acks

Besides bb has also the same issue, and it doesn't seem to be a problem. 
Some minor memory increase.

BR,
Nikos
----- Original Message ----- 
From: "Rene Kluwen" <[email protected]>
To: "'Victor Luchitz'" <[email protected]>
Cc: "'Kannel Devel'" <[email protected]>
Sent: Monday, August 02, 2010 4:36 PM
Subject: RE: [PATCH] Smppbox acks


Not receiving acks is only on topic if the connection is bad, somewhere.
Probably you will need to reconnect in that case anyway.


-----Original Message-----
From: Victor Luchitz [mailto:[email protected]]
Sent: Monday, 02 August, 2010 09:18
To: Rene Kluwen
Cc: Tomasz Konopka; Kannel Devel
Subject: Re: [PATCH] Smppbox acks

What bothers me a bit about this patch is that messages we don't
receive ack for are going to stay in memory forever, well, as long the
boxc is alive. A proper timeout mechanism would be a nice bonus.

2010/8/2 Rene Kluwen <[email protected]>:
> Here is a more advanced patch. Messages to bearerbox are acked, once the 
> deliver_sm_resp pdu is in.
> Also submit_sm pdu's get their responses, after bearerbox has acked the 
> message. And if not, a failure notice is returned.
> Before, message acks were given right away, without checking for failure 
> or rejection.
>
> Tomasz: Would it be possible for you to test this patch in your 
> environment?
>
> Victor: Would you review for stupidities?
>
> Comments are welcome.
>
> == Rene
>
>



-- 
Best regards,
 Victor Luchitz