Re: Patch: wtls

Hi,

patch committed to SVN.

Thanks,
Alexander Malysh

Am 15.09.2010 um 12:41 schrieb Nikos Balkanas:

> Here it is. Warnings were not created by -std=gnu99 but by all the other -W you have, specifically by -Wmissing-prototypes. This patch supplies the missing prototypes.
> 
> Using all your compiler flags, I was not able to reproduce your HMAC warning either in Solaris 10.5 or SuSE Linux. HMAC is defined in openssl, is not mine. I suspect you have some strange openssl setup in your Darwin.
> 
> BR,
> Nikos
> ----- Original Message ----- From: "Nikos Balkanas" <[email protected]>
> To: "Alexander Malysh" <[email protected]>
> Cc: "Kannel Devel" <[email protected]>
> Sent: Monday, September 13, 2010 11:36 AM
> Subject: Re: wtls branch merged
> 
> 
>> Thanks for bringing them to my attention. I cannot use -std=gnu99 in Solaris
>> and don't get those. I will compile in Linux and fix them.
>> 
>> BR,
>> Nikos
>> 
>> ----- Original Message ----- From: "Alexander Malysh" <[email protected]>
>> To: "Nikos Balkanas" <[email protected]>
>> Cc: "Kannel Devel" <[email protected]>
>> Sent: Monday, September 13, 2010 11:14 AM
>> Subject: Re: wtls branch merged
>> 
>> 
>> Hi Nikos,
>> 
>> patch commited to svn but we have more warnings wtls related:
>> 
>> gcc -std=gnu99 -D_REENTRANT=1 -I. -Igw -g -O2 -DDARWIN=1 -L/Developer/SDKs/MacOSX10.5.sdk/usr/lib  -I/Developer/SDKs/MacOSX10.5.sdk/usr/include -D_LARGE_FILES= -I/sw/include/libxml2  -I/sw/include -Wall -Wmissing-prototypes -Wmissing-declarations -Wnested-externs  -Winline -Wformat -Wformat-security -Wmissing-format-attribute -I/usr/include/openssl  -I/sw/include/mysql  -I/Users/alex/oracle/instantclient_10_2/sdk/include  -o wap/wtls-secmgr.o -c wap/wtls-secmgr.c
>> wap/wtls.c:280: warning: no previous prototype for ‘send_alert’
>> wap/wtls.c:401: warning: no previous prototype for ‘stateName’
>> gcc -std=gnu99 -D_REENTRANT=1 -I. -Igw -g -O2 -DDARWIN=1 -L/Developer/SDKs/MacOSX10.5.sdk/usr/lib  -I/Developer/SDKs/MacOSX10.5.sdk/usr/include -D_LARGE_FILES= -I/sw/include/libxml2  -I/sw/include -Wall -Wmissing-prototypes -Wmissing-declarations -Wnested-externs  -Winline -Wformat -Wformat-security -Wmissing-format-attribute -I/usr/include/openssl  -I/sw/include/mysql  -I/Users/alex/oracle/instantclient_10_2/sdk/include  -o wap/wtls_pdu.o -c wap/wtls_pdu.c
>> wap/wtls_pdu.c:359: warning: no previous prototype for ‘wtls_payload_guess_length’
>> gcc -std=gnu99 -D_REENTRANT=1 -I. -Igw -g -O2 -DDARWIN=1 -L/Developer/SDKs/MacOSX10.5.sdk/usr/lib  -I/Developer/SDKs/MacOSX10.5.sdk/usr/include -D_LARGE_FILES= -I/sw/include/libxml2  -I/sw/include -Wall -Wmissing-prototypes -Wmissing-declarations -Wnested-externs  -Winline -Wformat -Wformat-security -Wmissing-format-attribute -I/usr/include/openssl  -I/sw/include/mysql  -I/Users/alex/oracle/instantclient_10_2/sdk/include  -o wap/wtls_pdusupport.o -c wap/wtls_pdusupport.c
>> wap/wtls_pdusupport.c:892: warning: no previous prototype for ‘destroy_octstr’
>> wap/wtls_pdusupport.c:897: warning: no previous prototype for ‘destroy_octstr16’
>> wap/wtls_pdusupport.c:902: warning: no previous prototype for ‘destroy_octstr_fixed’
>> wap/wtls_pdusupport.c:913: warning: no previous prototype for ‘destroy_dhparams’
>> wap/wtls_pdusupport.c:920: warning: no previous prototype for ‘destroy_ecparams’
>> wap/wtls_pdusupport.c:969: warning: no previous prototype for ‘destroy_public_key’
>> wap/wtls_pdusupport.c:1004: warning: no previous prototype for ‘destroy_rsa_secret’
>> wap/wtls_pdusupport.c:1016: warning: no previous prototype for ‘destroy_key_exchange_id’
>> wap/wtls_pdusupport.c:1092: warning: no previous prototype for ‘destroy_signature’
>> wap/wtls_pdusupport.c:1126: warning: no previous prototype for ‘dump_void16’
>> gcc -std=gnu99 -D_REENTRANT=1 -I. -Igw -g -O2 -DDARWIN=1 -L/Developer/SDKs/MacOSX10.5.sdk/usr/lib  -I/Developer/SDKs/MacOSX10.5.sdk/usr/include -D_LARGE_FILES= -I/sw/include/libxml2  -I/sw/include -Wall -Wmissing-prototypes -Wmissing-declarations -Wnested-externs  -Winline -Wformat -Wformat-security -Wmissing-format-attribute -I/usr/include/openssl  -I/sw/include/mysql  -I/Users/alex/oracle/instantclient_10_2/sdk/include  -o wap/wtls_statesupport.o -c wap/wtls_statesupport.c
>> wap/wtls_statesupport.c:663: warning: no previous prototype for ‘wtls_P_hash’
>> wap/wtls_statesupport.c: In function ‘wtls_hmac_hash’:
>> wap/wtls_statesupport.c:737: warning: implicit declaration of function ‘HMAC’
>> wap/wtls_statesupport.c:737: warning: nested extern declaration of ‘HMAC’
>> wap/wtls_statesupport.c: At top level:
>> wap/wtls_statesupport.c:1103: warning: no previous prototype for ‘wtls_get_certificate’
>> wap/wtls_statesupport.c:1184: warning: no previous prototype for ‘isSupportedKeyEx’
>> wap/wtls_statesupport.c:1383: warning: no previous prototype for ‘add_all_handshake_data’
>> 
>> 
>> Thanks,
>> Alexander Malysh
>> 
>> Am 12.09.2010 um 13:15 schrieb Nikos Balkanas:
>> 
>>> Hi,
>>> 
>>> Reporting from Solaris 10.5 amd64, 64bit compilation. Configured --with-wtls=openssl
>>> 
>>> 1) Compilation: Clean. A couple of unrelated warnings fixed. Attaching patch.
>>> 
>>> 2) Emulators used:
>>> 
>>> a) Openwave SDK 6.2.2 wap: no problems (connection tested)
>>> b) Nokia NMBS 4.0: no problems (connection & connectionless tested)
>>> 
>>> Sites tested, following through links:
>>> 
>>> http://wap.google.com
>>> http://wap.yahoo.com
>>> http://m.facebook
>>> 
>>> Only facebook had a warning with nokia's emulator (b) about unsupported content. This was not observed with Openwave (a) and in any case it is related to wap, not wtls. The same happens in plain wtp communication.
>>> 
>>> Overall a succesful merge.
>>> 
>>> Thanks,
>>> Nikos
>>> ----- Original Message ----- From: "Alexander Malysh" <[email protected]>
>>> To: "Kannel Devel" <[email protected]>
>>> Cc: "Nikos Balkanas" <[email protected]>
>>> Sent: Sunday, September 12, 2010 1:04 PM
>>> Subject: wtls branch merged
>>> 
>>> 
>>>> Hi together,
>>>> 
>>>> just merged and commited wtls branch into trunk.
>>>> Please check it and let me know if something went wrong.
>>>> 
>>>> Thanks,
>>>> Alexander Malysh
>>> <kannel.diff>
> <kannel.diff>