Re: [PATCH] Opensmppbox and handling of stat txt field in DLR.

Hi,

1 more thing:

if (original_stat) {
      dlr_status = octstr_create(original_stat);

=> if (*original_stat){
     dlr_status = octstr_create(original_stat);

BR,
Nikos
----- Original Message ----- 
From: "XEN-Housing s.r.o." <[email protected]>
To: "Nikos Balkanas" <[email protected]>
Cc: <[email protected]>; <[email protected]>
Sent: Thursday, October 28, 2010 4:01 PM
Subject: Re: [PATCH] Opensmppbox and handling of stat txt field in DLR.


> Hi,
>
> fixed memory leak and missing stat field in original dlr text. thnx for
> help Nikos ;)
>
> Slavoj.
>
> DΕa 28. 10. 2010 14:47, Nikos Balkanas wrote / napΓ­sal(a):
>> Hi,
>>
>> Looks good. Opensmppbox maintainer is Rene. You might want to cc him
>> for smppbox patches.
>>
>> 3 observations:
>>
>> 1) You write straight C. I have no problem with it, and in fact I
>> prefer it. But other people might object to it, and would prefer
>> octstr_* wrappers. Please review gwlib/octstr.h and replace some of
>> the functions like strstr and sscanf with those.
>> 2) What if there is no stat: field in the DLR? Handle this case, too.
>> 3) You need to octstr_destroy(dlr_status) when done, else you will
>> have a memory leak.
>>
>> +1
>>
>> BR,
>> Nikos
>> ----- Original Message ----- From: "XEN-Housing s.r.o."
>> <[email protected]>
>> To: <[email protected]>
>> Sent: Thursday, October 28, 2010 3:09 PM
>> Subject: [PATCH] Opensmppbox and handling of stat txt field in DLR.
>>
>>
>>> Hello there.
>>>
>>> I was wroten another small patch to opensmppbox. When i got from smpp
>>> smsc an fail status due sms was expired, at stat field of message was
>>> EXPIRED, but when DLR passes trought opensmppbox, target client got
>>> fixed UNDELIV text. Original code doesnot reflect original reason why
>>> sms delivery failed.
>>>
>>> Please review that code, if there are no memory leaks, or if that code
>>> should be applicated to all message statuses, not only DLR_FAIL and
>>> DLR_SMSC_FAIL.
>>>
>>> Slavoj.
>>>
>>>
>>
>
>