Re: [PATCH] Opensmppbox and handling of stat txt field in DLR.

Am 29.10.2010 um 17:51 schrieb XEN-Housing s.r.o.:

> Hi Alex,
> 
> i will, but i was bussy for last few hours with other project. I am new one on that project and i did not findout some docs for devels where will be best practices described and i am not familiar with used wrappers. So it takes me a little bit longer to get deeper in that project. Till now i was just an user of kannel ;)

welcome to kannel as developer :)

> 
> So, i will make changes, put here another version of fix to revew ;)
> 
> Slavoj.
> 
> Dňa 29. 10. 2010 17:04, Alexander Malysh  wrote / napísal(a):
>> Hi,
>> 
>> please kill strstr we have wrapper functions for Octstr (octstr_search_cstr(...)) and try to use octstr_XX functions whether it's possible.
>> 
>> Thanks,
>> Alex
>> 
>> Am 28.10.2010 um 15:01 schrieb XEN-Housing s.r.o.:
>> 
>>> Hi,
>>> 
>>> fixed memory leak and missing stat field in original dlr text. thnx for help Nikos ;)
>>> 
>>> Slavoj.
>>> 
>>> Dňa 28. 10. 2010 14:47, Nikos Balkanas wrote / napísal(a):
>>>> Hi,
>>>> 
>>>> Looks good. Opensmppbox maintainer is Rene. You might want to cc him for smppbox patches.
>>>> 
>>>> 3 observations:
>>>> 
>>>> 1) You write straight C. I have no problem with it, and in fact I prefer it. But other people might object to it, and would prefer octstr_* wrappers. Please review gwlib/octstr.h and replace some of the functions like strstr and sscanf with those.
>>>> 2) What if there is no stat: field in the DLR? Handle this case, too.
>>>> 3) You need to octstr_destroy(dlr_status) when done, else you will have a memory leak.
>>>> 
>>>> +1
>>>> 
>>>> BR,
>>>> Nikos
>>>> ----- Original Message ----- From: "XEN-Housing s.r.o."<[email protected]>
>>>> To:<[email protected]>
>>>> Sent: Thursday, October 28, 2010 3:09 PM
>>>> Subject: [PATCH] Opensmppbox and handling of stat txt field in DLR.
>>>> 
>>>> 
>>>>> Hello there.
>>>>> 
>>>>> I was wroten another small patch to opensmppbox. When i got from smpp
>>>>> smsc an fail status due sms was expired, at stat field of message was
>>>>> EXPIRED, but when DLR passes trought opensmppbox, target client got
>>>>> fixed UNDELIV text. Original code doesnot reflect original reason why
>>>>> sms delivery failed.
>>>>> 
>>>>> Please review that code, if there are no memory leaks, or if that code
>>>>> should be applicated to all message statuses, not only DLR_FAIL and
>>>>> DLR_SMSC_FAIL.
>>>>> 
>>>>> Slavoj.
>>>>> 
>>>>> 
>>> <dlr_undeliv_status2.diff>
>