Re: Spelling and client side ssl certificate patch

Hi Luca,

+1 except this part:

     cfg_get_bool(&smpp->use_ssl, grp, octstr_imm("use-ssl"));
+    if (smpp->use_ssl)
 #ifndef HAVE_LIBSSL
-    if (smpp->use_ssl)
         panic(0, "SMPP: Can not use 'use-ssl' without SSL support compiled in.");

this is wrong... we want to panic only if no ssl support compiled in...

Thanks,
Alexander Malysh

Am 02.11.2010 um 00:31 schrieb Luca Corti:

> On Mon, 2010-11-01 at 12:15 +0100, Alexander Malysh wrote:
>> SSL client patch is not commited because you have to implement this option
>> for SMSC modules first....
> 
> The new patch adds the implementation of client SSL certificate support
> to SMPP, which is the only SMSC using SSL. It also adds documentation of
> the new option to the userguide.
> 
> If use-ssl and the ssl-client-certkey-file option are both specifed
> conn_open_ssl uses the provided pem file for the ssl connection in
> tranceiver/transmitter/receiver modes, else the old behaviour applies.
> 
> ciao
> 
> Luca
> <kannel_smsc_smpp_ssl-client-certkey-file>