Re: Spelling and client side ssl certificate patch

Hi Luca,

you are right. +1 for your patch

Thanks,
Alexander Malysh

Am 02.11.2010 um 12:10 schrieb Luca Corti:

> On Tue, 2010-11-02 at 09:54 +0100, Alexander Malysh wrote:
>> Hi Luca,
>> 
>> +1 except this part:
>> 
>>     cfg_get_bool(&smpp->use_ssl, grp, octstr_imm("use-ssl"));
>> +    if (smpp->use_ssl)
>> #ifndef HAVE_LIBSSL
>> -    if (smpp->use_ssl)
>>         panic(0, "SMPP: Can not use 'use-ssl' without SSL support compiled in.");
>> 
>> this is wrong... we want to panic only if no ssl support compiled in...
> 
> 
> Looks correct to me. The test is moved out of the ifndef so that it
> panics if use_ssl is true and LIBSSL is not defined, else if use_ssl is
> true and LIBSSL is defined it tries to get the ssl-client-certkey-file.
> 
> if (smpp->use_ssl)
> #ifndef HAVE_LIBSSL
>     panic(0, "SMPP: Can not use 'use-ssl' without SSL support compiled
> in.");
> #else
>     smpp->ssl_client_certkey_file = cfg_get(grp,
> octstr_imm("ssl-client-certkey-file"));
> #endif
> 
> 
> Or am I missing something?
> 
> thanks
> 
> Luca
>