Re: useful patches for everyone

Hi,

because we should not overload kannel with unneeded config options if it might be simulated with existing
possibilities.

at least 2 possibilities how to do it:
1) configure it in extra directory and include/don't include it by start
2) start bearerbox and then stop these links in start/init script

This is so special that I don't really see any requirement to have such config option.

Thanks,
Alex

Am 18.04.2011 um 17:28 schrieb Juan Nin:

> Hi Alex!
> 
> I find that patch to be helpful too.
> 
> There's many times that you have test binds setup for example, that you don't normally want them running, except for on certain moments.
> It's much easier to have them already configured, not starting at boot, and just start/stop them whenever needed, than having to add/remove them, comment or whatever...
> 
> Of course you can do it that other way, and it's not that it's difficult to do it, but why not add something that can be useful and provides a smoother way of doing it?
> Evenmore when it's a small patch like that one...
> 
> Regards,
> 
> Juan
> 
> 
> On Mon, Apr 18, 2011 at 5:31 AM, Alexander Malysh <[email protected]> wrote:
> Hi Hillel,
> 
> I don't see any need for this patch. Don't define this SMSC if you don't need this started.
> 
> Thanks,
> Alexander Malysh
> 
> Am 18.04.2011 um 08:30 schrieb Hillel:
> 
> > Hi Alex,
> >
> > Thanks for committing Alejandro Guerrieri's patch of speed/throughput meters
> > on a per-smsc basis.
> >
> > Please will you commit Alejandro Guerrieri's other patch below that adds a
> > parameter "start-at-boot" which means you don't need to start the SMSC at
> > boot.
> >
> > 2)Patch that adds a parameter "start-at-boot" (defaults to true if
> >>> not present) that allows you to prevent an smsc bind from being started
> >> when
> >>> booting.
> >>>
> >>> More details and the download link here:
> >>>
> >>> http://www.blogalex.com/archives/250
> >>>
> >>> regards
> >
> > -----Original Message-----
> > From: Alexander Malysh [mailto:[email protected]] On Behalf Of
> > Alexander Malysh
> > Sent: 28 February 2011 07:25 PM
> > To: Hillel
> > Subject: Re: useful patches for everyone
> >
> > Hi,
> >
> > I will look into this, sorry too busy last time...
> >
> > Alex
> >
> > Am 28.02.2011 um 16:12 schrieb Hillel:
> >
> >> Hi Alex,
> >>
> >> We are one of your fans for the work you do on Kannel.
> >> Please would you either commit these patches or email back the problems so
> >> Alejandro Guerrieri can fix his code and send them in again. I asked for
> >> this on the devel group but got no response.  These are useful patches for
> >> everyone.
> >>
> >> thanks
> >>
> >> ----------------------------------------------------------------------
> >>
> >> Message: 1
> >> Date: Tue, 25 Jan 2011 15:08:00 +0200
> >> From: "Hillel" <[email protected]>
> >> To: <[email protected]>
> >> Cc: [email protected]
> >> Subject: [PATCH] on speed/throughput meters and "start-at-boot"
> >>      parameter
> >> Message-ID:
> >>
> >>
> > <!&!AAAAAAAAAAAYAAAAAAAAAB3Njb3bAfxAmkjnYfWS0L3CgAAAEAAAAINZGABxAxZDgHsAcqIW
> >> [email protected]>
> >>
> >> Content-Type: text/plain;    charset="us-ascii"
> >>
> >> Hi Juan,
> >>
> >> Thanks for your response.  Hopefully, the Kannel SVN maintainers will soon
> >> add these useful patches or request they are improved.
> >>
> >> rgds
> >>
> >> Date: Fri, 21 Jan 2011 00:26:32 -0200
> >> From: Juan Nin <[email protected]>
> >> To: Kannel Devel <[email protected]>
> >> Subject: Re: speed/throughput meters on a per-smsc basis and
> >>      start-at-boot paramater
> >> Message-ID:
> >>      <[email protected]>
> >> Content-Type: text/plain; charset=ISO-8859-1
> >>
> >> I can't say much about the code, but the features are both very useful!!!
> >>
> >>
> >> On Tue, Jan 18, 2011 at 10:15 AM, Hillel <[email protected]> wrote:
> >>> Hi,
> >>>
> >>> We would like to wish all Kannel uses and developers a great 2011.
> >>> We also want to thank all those that have contributed patches and
> >> especially
> >>> the Kannel developer team, that evaluates the patches and submits them.
> >>>
> >>> We are +1 on the two patches of Alejandro Guerrieri mentioned below.
> >>> Thanks to him for submitting them.
> >>> Please will others comment on these patches so they can be hopefully
> > added
> >>> to SVN.
> >>>
> >>> 1)Patch to have speed/throughput meters on a per-smsc basis, in
> >>> addition to the totals currently available.
> >>>
> >>> More details and a link to download it here:
> >>>
> >>> http://www.blogalex.com/archives/232
> >>>
> >>> 2)Patch that adds a parameter "start-at-boot" (defaults to true if
> >>> not present) that allows you to prevent an smsc bind from being started
> >> when
> >>> booting.
> >>>
> >>> More details and the download link here:
> >>>
> >>> http://www.blogalex.com/archives/250
> >>>
> >>> regards
> >>>
> >>>
> >>>
> >>>
> >>>
> >>
> >>
> >>
> >>
> >
> 
>