RE: useful patches for everyone
Richard Crawshaw <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <6441F32ADEF2A84283CFB756673790230272336E57C8@MAILSVR.truancycall.com> |
For what it's worth, I would like to add my voice to the call for the inclusion of this addition to the configuration options. I would find this facility really, really useful. Richard From: [email protected] [mailto:[email protected]] On Behalf Of Juan Nin Sent: 19 April 2011 04:42 To: Kannel Devel Subject: Re: useful patches for everyone 2011/4/19 Nikos Balkanas <[email protected]<mailto:[email protected]>> Hi, wapbox must be kept around because of backwards compatibility, that is a must for all open source software. Users are still using it. Nikos, that was just an example to clarify that not everybody is interested on the same things, and that that doesn't mean it's not useful for others I could have mentioned other directives I don't use instead, and not wapbox Finally I would like to add my support for keeping configuration explosion in check. Otherwise, what a few people might gain in convenience, a lot of people might have to pay for it in terms of kannel support due to more difficult configuration. Some golden rules in configuration are: 1) KISS We're not talking about a complicated configuration option that requires support nor anything, this is something really simple... 2) Don't expand it, unless it is absolutely necessary. I consider it necessary, as other people seem to consider it too who are in favor of the patch too Having to modify your init script to shutdown smscs after they have been already started at boot looks like a horrible hack to me to be honest... you either want an smsc to start or not to start, but not to be started and then quickly shutdown cause it's not what you really desire... and being able to already have a configuration loaded and start/stop an smsc without needing to access the server via ssh and manually doing stuff seems like a very interesting thing to be able to do... Can you do it via the other way? Yes, you can, but doesn't seem like a very clean or tidy way to do it... Again, we're not talking about a radical code change, nor anything, it's something really simple... Stopping service to modify configuration is a no-no. Commenting a configuration file off-line is convenience. For me and many others convenience is having a directive like start-at-boot, and not having it is a nuisance :) Juan My 2 cents, Nikos ----- Original Message ----- From: Juan Nin To: Kannel Devel Sent: Tuesday, April 19, 2011 4:41 AM Subject: Re: useful patches for everyone That's what we do today, but the idea is not to have to do any "extra" work, neither having to comment/uncomment things out, nor have to add/remove config files. Having the start-at-boot directive allows you to just keep the configuration defined, but the smsc does not start. So anytime you need it, you just use the start-smsc and then the stop-smsc. This is much cleaner IMHO than having to do all the extra manual work, no matter how easy that manual work it may be. A similar discussion was held some months ago, can't remember what new directive it was, where the directive was finally added, since it was seen it was helpful. Not all directives are used by everyone or may be useful for everybody, that happens on any piece of software, but does not mean it's not useful, nor that it should not be added. I don't care about the WAP related parts of Kannel for example, and that doesn't mean I believe they should not exist. Adding useful things to Kannel is something that makes Kannel a better product, so I don't really see why not to add it. Maybe if it was something complicated that really messed up with the code, could be, but this is definitely not the case. Just my 2 cents. 2011/4/18 Nikos Balkanas <[email protected]<mailto:[email protected]>> What about the HTTP command start-smsc: It reloads the smsc and starts them from configuration. Therefore you could have the smsc commented out at start, then enable it in the configuration and start it from the web interface, without stooping kannel. Is that not adequate? BR, Nikos ----- Original Message ----- From: "Thomas Gottgens" <[email protected]<mailto:[email protected]>> To: "Alvaro Cornejo" <[email protected]<mailto:[email protected]>> Cc: "Alexander Malysh" <[email protected]<mailto:[email protected]>>; "Kannel Devel" <[email protected]<mailto:[email protected]>> Sent: Monday, April 18, 2011 11:24 PM Subject: Re: useful patches for everyone Hello, i second that. Having the ability to start kannel with some of the binds down is so much easier in HA/Failover environments. Monday, April 18, 2011, 8:31:05 PM, you wrote: AC> Hi Alex AC> Another use would be when having backup links. I do use over 20 modems AC> but not have all enabled at start. In order to not to have to reload AC> kannel when a new modem is needed, I do start kannel and then stop all AC> the backup modems and I have to do the same whenever I restart kannel AC> or the server AC> I'll love to have this feature in standard kannel -- Best regards, Thomas mailto:[email protected]<mailto:[email protected]>