RE: [PATCH] handling of non-latin GSM subset in opensmppbox
"Rene Kluwen" <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <[email protected]> |
It's what I meant: to make it configurable, so you can "expect" an arbitrary charset and convert it to UTF-8, which bearerbox expects. By this, I mean a separate configuration item for opensmppbox which should not to be confused with the alt-charset configuration item (with the same name) of group = smsc in bearerbox. About your group = client. That might be an option, in combination with the PAM authentication that is already there. That way, also different route-to-smsc values can also be supported. Will look into that! == Rene -----Original Message----- From: Nikos Balkanas [mailto:[email protected]] Sent: Monday, 09 May, 2011 00:59 To: Rene Kluwen; 'Nii Ako Ampa-Sowa'; [email protected] Subject: Re: [PATCH] handling of non-latin GSM subset in opensmppbox Hi Rene, In my previous comment I said that making alt_charset is not necessary since by using a full iso and decoding with the same one, it would yield the original without errors, although it would be preferable to make it configurable. It turns out that not doing so, it would contradict kannel architecture. In such a content bearerbox, doesn't try simply to recover original charset, rather with alt_charset it tries to convert it to a new charset compatible with the smsc. therefore it is necessary to make it configurable. Since the list of features/client connection should be epandable, I would recommend skipping the text file alltogether and instead create a new configuration group, ie: group = client ... PS: Charset code was lift off gw/smsc/smsc_smpp.c. It needs to be converted to UTF-8 as well. BR, Nikos ----- Original Message ----- From: Rene Kluwen To: 'Nii Ako Ampa-Sowa' ; [email protected] Sent: Monday, May 09, 2011 1:39 AM Subject: RE: [PATCH] handling of non-latin GSM subset in opensmppbox Patch committed. Current revision of opensmppbox is 61. Still todo: Make a configuration entry for alt-charset. Even though it is not really necessary at the moment. Log line: 2011-05-09 Rene Kluwen <rene.kluwen at chimit.nl> * gw/opensmppbox.c: Default GSM character set is converted to UTF-8 (Kannel's internal way of exchanging messages). The facilitates foreign (e.g. greek) characters. Thanks to Nii Ako Ampa-Sowa (ampasowa at gmail.com) for the patch. == Rene From: [email protected] [mailto:[email protected]] On Behalf Of Nii Ako Ampa-Sowa Sent: Friday, 06 May, 2011 23:04 To: [email protected] Subject: [PATCH] handling of non-latin GSM subset in opensmppbox Hi, opensmppbox doesn't seem to handle the non-Latin subset of the GSM character set very well. This affects the Euro sign as well as Greek characters. Attached is a patch that switches from using the Latin1 conversion routine to the UTF-8 version. Nii
smime.p7s
(application/x-pkcs7-signature, 6.2 KB) - not displayed