Re: Kannel 1.5.0 compilation

Hi,

Actually you already applied the patch to the svn, so it still has problems:

HAVE_SYSLOG is defined from configuration for Solaris.
Additionally there is no SYSLOG_NAMES defined in Solaris headers.

So apart from CODE you would need facilitynames as well. And not all 
constants defined in facilitynames in Linux are defined in Solaris.
Therefore my suggestion for a simple fix will not work.

By #undef HAVE_SYSLOG in gwlib/log.c, everything compiles clean. So 
configuration needs to be fixed as well at this point. This means that 
syslog fucntionality that used to work in Solaris, is not any more, and 
possibly other *nix OSs as well. I think that qualifies it as a broken 
feature.

Let me know if you need any extra input from Solaris,
Nikos
----- Original Message ----- 
From: "Nikos Balkanas" <[email protected]>
To: "Alexander Malysh" <[email protected]>
Cc: <[email protected]>
Sent: Saturday, July 23, 2011 4:04 PM
Subject: Re: Kannel 1.5.0 compilation


> Hi Alex,
>
> Thanks for the fast response.
>
> Solaris 10 has both /usr/include/syslog.h and /usr/include/sys/syslog.h, 
> where it defines constants. This is update 8, which is very recent. 
> However, as in some of the other include files, there are some 
> discrepancies, and CODE is missing. Now Solaris has System V stewardship, 
> while Linux is based more on BSD.
>
> Solaris defines syslog.h as:
>
> #define _SYSLOG_H
>
> Therefore your patch will take out all syslog.h definitions in Solaris, 
> which is an overkill, since syslog worked fine in Solaris before CODE.
>
> I would suggest, that it is handled in the configuration script and 
> gw-config.h like the discrepancy in gethostbyname. It would be a much 
> simpler patch, just to define there CODE if it is not defined.
>
> BR,
> Nikos
> ----- Original Message ----- 
> From: "Alexander Malysh" <[email protected]>
> To: "Nikos Balkanas" <[email protected]>
> Cc: <[email protected]>
> Sent: Saturday, July 23, 2011 1:08 PM
> Subject: Re: Kannel 1.5.0 compilation
>
>
>> Hi,
>>
>> CODE is defined in syslog.h. Does Solaris don't have syslog.h?
>>
>> Please try attached patch.
>>
>> Thanks,
>> Alex
>>
>
>
> --------------------------------------------------------------------------------
>
>
>
>
> Am 22.07.2011 um 21:29 schrieb Nikos Balkanas:
>
>> Hi,
>>
>> I am getting this trying to build latest kannel svn in Solaris:
>>
>> gwlib/log.c:155: error: syntax error before "CODE"
>>
>> gwlib/log.c:155:
>>
>> /*
>> * Decode the syslog name to its int value
>> */
>> static int decode(char *name, CODE *facilities)
>> {
>>    register CODE *c;
>>
>>
>> Where is this CODE defined? Couldn't find it anywhere in kannel sources 
>> and is not a C primitive type. Is it a Linux thingie?
>>
>> BR,
>> Nikos
>>
>
>