[PATCH] start-at-boot / userguide
Juan Nin <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <[email protected]> |
See attached patch for adding the start-at-boot directive (smsc group) to the Kannel User's Guide. This was the only missing part so as to get Alejandro Guerrieri's start-at-boot patch into the main tree. Regards, Juan On 5/15/11 6:53 AM, Hillel wrote: > Hi Alejandro, > > Have you been able to commit your start-at-boot patch? > > thanks > > From: Alejandro Guerrieri<[email protected]> > To: Alexander Malysh<[email protected]> > Cc: Kannel Devel<[email protected]> > Subject: Re: useful patches for everyone > Message-ID:<[email protected]> > Content-Type: text/plain; charset=us-ascii > > Thanks Alex, > > I'll write the userguide part and commit. > > Regards, > > Alex > -- > Alejandro Guerrieri > [email protected] > > > > On 19/04/2011, at 11:52, Alexander Malysh wrote: > >> Hi Alex, >> >> IMHO this option is not really needed and is only workaround about a fact > that bearerbox >> is unable to reload configuration without restart. But reload is much > bigger implementation as >> this simple "hack". If this "hack" will help much people to do cleaner > configuration now then I'm >> not voting against this feature. >> >> Alex, please update userguide and commit this patch if nobody has any > objections. >> I'm +0 >> >> Thanks, >> Alexander Malysh >> >> Am 19.04.2011 um 10:49 schrieb Alejandro Guerrieri: >> >>> For KISS's sake, this doesn't clutter configuration nor breaks backwards > compatibility. It doesn't hurt performance either. >>> If you don't want to use it just ignore it completely, the default > behavior if the directive is missing is to start the smsc at boot as usual, > so no harm's done. >>> Where do we trace the "absolutely necessary" line is of course fuzzy, but > from what I read seems like other users would find it useful as well. >>> Regards, >>> -- >>> Alejandro Guerrieri >>> [email protected] >>> >>> >>> >>> On 19/04/2011, at 05:19, Nikos Balkanas wrote: >>> >>>> Hi, >>>> >>>> wapbox must be kept around because of backwards compatibility, that is a > must for all open source software. Users are still using it. >>>> Finally I would like to add my support for keeping configuration > explosion in check. Otherwise, what a few people might gain in convenience, > a lot of people might have to pay for it in terms of kannel support due to > more difficult configuration. Some golden rules in configuration are: >>>> 1) KISS >>>> 2) Don't expand it, unless it is absolutely necessary. >>>> >>>> Stopping service to modify configuration is a no-no. Commenting a > configuration file off-line is convenience. >>>> My 2 cents, >>>> Nikos >>>> ----- Original Message ----- From: Juan Nin >>>> To: Kannel Devel >>>> Sent: Tuesday, April 19, 2011 4:41 AM >>>> Subject: Re: useful patches for everyone >>>> >>>> >>>> That's what we do today, but the idea is not to have to do any "extra" > work, neither having to comment/uncomment things out, nor have to add/remove > config files. >>>> >>>> Having the start-at-boot directive allows you to just keep the > configuration defined, but the smsc does not start. >>>> So anytime you need it, you just use the start-smsc and then the > stop-smsc. >>>> This is much cleaner IMHO than having to do all the extra manual work, > no matter how easy that manual work it may be. >>>> >>>> A similar discussion was held some months ago, can't remember what new > directive it was, where the directive was finally added, since it was seen > it was helpful. >>>> Not all directives are used by everyone or may be useful for everybody, > that happens on any piece of software, but does not mean it's not useful, > nor that it should not be added. I don't care about the WAP related parts of > Kannel for example, and that doesn't mean I believe they should not exist. > Adding useful things to Kannel is something that makes Kannel a better > product, so I don't really see why not to add it. Maybe if it was something > complicated that really messed up with the code, could be, but this is > definitely not the case. >>>> >>>> Just my 2 cents. >>>> >>>> >>>> 2011/4/18 Nikos Balkanas<[email protected]> >>>> >>>> What about the HTTP command start-smsc: >>>> >>>> It reloads the smsc and starts them from configuration. Therefore you > could have the smsc commented out at start, then enable it in the > configuration and start it from the web interface, without stooping kannel. > Is that not adequate? >>>> BR, >>>> Nikos >>>> ----- Original Message ----- From: "Thomas Gottgens" > <[email protected]> >>>> To: "Alvaro Cornejo"<[email protected]> >>>> Cc: "Alexander Malysh"<[email protected]>; "Kannel Devel" > <[email protected]> >>>> Sent: Monday, April 18, 2011 11:24 PM >>>> >>>> Subject: Re: useful patches for everyone >>>> >>>> >>>> >>>> Hello, >>>> >>>> i second that. Having the ability to start kannel with some of the binds > down >>>> is so much easier in HA/Failover environments. >>>> >>>> Monday, April 18, 2011, 8:31:05 PM, you wrote: >>>> >>>> AC> Hi Alex >>>> >>>> AC> Another use would be when having backup links. I do use over 20 > modems >>>> AC> but not have all enabled at start. In order to not to have to reload >>>> AC> kannel when a new modem is needed, I do start kannel and then stop > all >>>> AC> the backup modems and I have to do the same whenever I restart > kannel >>>> AC> or the server >>>> >>>> AC> I'll love to have this feature in standard kannel >>>> >>>> -- >>>> Best regards, >>>> Thomas mailto:[email protected] >>>> >>> > > > > >
start-at-boot_userguide.patch
(text/plain, 952 B)
Index: doc/userguide/userguide.xml
===================================================================
--- doc/userguide/userguide.xml (revision 4924)
+++ doc/userguide/userguide.xml (working copy)
@@ -2889,7 +2889,14 @@
<entry valign="bottom">url-encoded string with properly formatted meta-data pair(s)..
See <xref linkend="meta-data"> for an explanation about meta-data configuration and encoding.
</entry>
- </row>
+ </row>
+
+ <row><entry><literal>start-at-boot</literal></entry>
+ <entry><literal>boolean</literal></entry>
+ <entry valign="bottom">Optional, defines if the bind is to be started or not when booting or when adding it with the add-smsc HTTP administration command. If set to 'false' the bind will start as 'dead' and will require a start-smsc command to activate it. Defaults to 'true' if not present.</entry>
+ </row>
+
+
</tbody>
</tgroup>
</table>