RE: at smsc bug

These are the changes that were made since the version that worked (see
attached document).

I tried both hardware-flow-control = true and false. Both gave me the same
error.

 

== Rene

 

 

From: Andreas Fink [mailto:[email protected]] 
Sent: Monday, 06 August, 2012 18:07
To: Rene Kluwen
Subject: Re: at smsc bug

 

please run it in with log-level=0 and send the output of the logfile so we
can see the backtrace of the issue.

 

On 06.08.2012, at 18:01, Rene Kluwen <[email protected]> wrote:





When starting current head revision in combination with a huwaei usb modem,
I get the following.

An older version of bearerbox has been working perfectly for some months
already. This happened when I tried to upgrade.

This is on a production machine, so it is a little bit hard to debug. The
only thing that left me was downgrading again.

 

Logs:

 

2012-08-06 17:55:07 [6608] [0] INFO:
----------------------------------------

2012-08-06 17:55:07 [6608] [0] INFO: Kannel bearerbox II version svn-r4988
starting

2012-08-06 17:55:07 [6608] [0] INFO: MAIN: Start-up done, entering mainloop

2012-08-06 17:55:07 [6608] [0] DEBUG: AT2[hvgsmsc]: start called

2012-08-06 17:55:07 [6608] [6] DEBUG: Thread 6
(gw/smsc/smsc_at.c:at2_device_thread) maps to pid 6608.

2012-08-06 17:55:07 [6608] [6] DEBUG: AT2[hvgsmsc]: detecting modem speed.

2012-08-06 17:55:07 [6608] [6] INFO: AT2[hvgsmsc]: opening device

2012-08-06 17:55:07 [6608] [6] DEBUG: AT2[hvgsmsc]: device opened. Telnet
mode = 0

2012-08-06 17:55:07 [6608] [6] PANIC: ./bearerbox [0x80e8ebd]

2012-08-06 17:55:07 [6608] [6] PANIC: [0x160440]

2012-08-06 17:55:07 [6608] [6] PANIC: ./bearerbox [0x808764d]

2012-08-06 17:55:07 [6608] [6] PANIC: ./bearerbox [0x80877ca]

2012-08-06 17:55:07 [6608] [6] PANIC: ./bearerbox [0x80d3541]

2012-08-06 17:55:07 [6608] [6] PANIC: /lib/libpthread.so.0 [0x9bc45b]

2012-08-06 17:55:07 [6608] [6] PANIC: /lib/libc.so.6(clone+0x5e) [0x91423e]

Segmentation fault

 

Config:

 

group = smsc

smsc-id = hvgsmsc

smsc = at

modemtype=auto

device=/dev/ttyUSB0

my-number=+316xxxxxxx

pin = 0000

connect-allow-ip = 127.0.0.1

sms-center = "+316540881000"

log-level = 0

sim-buffering = true

 

group = modems

id = huawei

name = "Huawei"

detect-string = "huawei"

detect-string2 = "K3765"

init-string = "ATQ0 V1 E1 S0=0 &C1 &D2 +FCLASS=0; +CNMI=1,1,0,2,0; +CMEE=1"

message-storage = "SM"

message-start = 0

Index: smsc_at.c
===================================================================
--- smsc_at.c   (revision 4988)
+++ smsc_at.c   (working copy)
@@ -1,7 +1,7 @@
 /* ====================================================================
  * The Kannel Software License, Version 1.0
  *
- * Copyright (c) 2001-2012 Kannel Group
+ * Copyright (c) 2001-2010 Kannel Group
  * Copyright (c) 1998-2001 WapIT Ltd.
  * All rights reserved.
  *
@@ -249,12 +249,7 @@
     tios.c_iflag |= IGNPAR; /* ignore parity */
     tios.c_iflag &= ~INPCK;
 #if defined(CRTSCTS)
-    if(privdata->modem->hardware_flow_control) {
-        tios.c_cflag |= CRTSCTS; /* enable hardware flow control */
-    }
-    else {
-        tios.c_cflag &= ~CRTSCTS; /* disable hardware flow control */
-    }
+    tios.c_cflag |= CRTSCTS; /* enable hardware flow control */
 #endif
     tios.c_cc[VSUSP] = 0; /* otherwhise we can not send CTRL Z */

@@ -2852,8 +2847,6 @@
             modem->message_start = 1;

         cfg_get_bool(&modem->enable_mms, grp, octstr_imm("enable-mms"));
-        modem->hardware_flow_control = 1;
-        cfg_get_bool(&modem->hardware_flow_control, grp, octstr_imm("hardware-flow-control"));

         /*
         if (modem->message_storage == NULL)