RE: [PATCH] opensmppbox: message id generation fix

Patch committed. Current trunk version is now 74.

Note that upgrading a running opensmppbox instance will break dlr's.

 

From: devel [mailto:[email protected]] On Behalf Of Alexander
Kovalenko
Sent: woensdag 7 augustus 2013 16:25
To: [email protected]
Subject: [PATCH] opensmppbox: message id generation fix

 

Greetings.

Recently we've noticed that under load opensmppbox may return same message
ids in submit_sm_resp responses.

Looking at the sources I see, that it returns only first 8 chars of
generated UUID. This is not correct, because these bytes may be same for
different UUIDs. I suppose it was coded in such way to support both smpp
v3.3 and v3.4. According to protocol v3.3 this field must be max 9 chars
including '\0'. But in v3.4 it's allowed to have up to 65 chars.

There is our patch in attachment. It was created against
https://svn.kannel.org/opensmppbox/trunk , revision 73.

For v3.3 opensmppbox will return only first 8 chars for UUID as before, but
for v3.4 and above it will return full generated UUID.

-- 
With best regards,
Alexander Kovalenko
Ardas Group Inc.
www.ardas.dp.ua