Re: [Patch] smsc connection status url

Hi,

idea is OK but implementation is wrong.

1) +	http_start_request(caller, HTTP_METHOD_GET, url, request_headers,
+					   NULL, 1, NULL, NULL);

I'm missing consumer who reads completed requests otherwise you will leak memory.

2) why do you add it to smpp module instead of to add it to bb_smscconn? Here it will work for all
smsc types.

Alex

Am 13.08.2013 um 11:32 schrieb Semion Spivak <[email protected]>:

> Hi all,
> 
> I'm trying to modify the bearerbox so the bb would make a HTTP GET request to a specific url every time a SMPP SMSC client loses the connection or comes back online.
> 
> All this to ensure that our routing app reacts as quickly as possible when the connection fails and routes the traffic away to another SMSC. Currently we are polling the Kannel's status page once a minute, which is not adaptive enough.
> 
> We considered designing our routing app to state several smsc-ids (like smsc-id=primary;secondary) when submitting the message to Kannel, so Kannel would choose the secondary smsc in case the primary is not available, but we saw an overhead of updating an actual price, user's balance and smsc-id of the message after it has been submitted to the upstream SMSC.
> 
> The patch is made against rev 5043 with `svn diff --patch-compatible` command. Not being much confident with C++ myself, I'm asking for your advice - are there any critical flaws I'm not aware of?
> 
> This is a basic version, and there is a room for improvement, like adding templates to the url for passing smsc host, port, username, service-type etc., and adding this notifications to other smsc types.
> 
> And as allways, if anyone finds it usefull, I would be honored if you add it to the Kannel codebase.
> 
> Thanks a lot in advance,
> -- 
> Regards,
> Semion Spivak,
> SmsCoin.com
> <smsc_status_url.patch>