Re: [PATCH] No PANIC on failing store_load()

+1 for this patch!

I remember struggling with sqlbox without injecting proper sms_type =
2 and after restart kannel was crashing.

I had to manually clean specific message out of spool.



2013/9/16 Porter, Kelvin <[email protected]>:
> Hi,
>
> This sounds like a good change.  This principle should be applied, in general.
>
> Regards,
>
> Kelvin R. Porter
>
> -----Original Message-----
> From: devel [mailto:[email protected]] On Behalf Of Stipe Tolj
> Sent: Monday, September 16, 2013 10:59 AM
> To: [email protected]
> Subject: [PATCH] No PANIC on failing store_load()
>
> Hi list,
>
> attached is a very simple change in behavior in being more "runtime"
> constraining, in case a message in the spool has an invalid 'sms_type'
> we SHOULD NOT PANIC i.e. but rather dump an ERROR entry and try to continue.
>
> Otherwise we may enter an infinite PANIC/restart loop for cases that such messages get somehow injected to the spool.
>
> If no objections, will be committing soon.
>
> Stipe
>
> --
> -------------------------------------------------------------------
> Kölner Landstrasse 419
> 40589 Düsseldorf, NRW, Germany
>
> tolj.org system architecture      Kannel Software Foundation (KSF)
> http://www.tolj.org/              http://www.kannel.org/
>
> mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
> -------------------------------------------------------------------
>