RE: [PATCH] No PANIC on failing store_load()
"Rene Kluwen" <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <[email protected]> |
Also +1. A common "error" when using sqlbox is not setting sms_type to the proper value (2) whilst inserting an MT to send_sms. This will probably fill the store with messages with invalid sms_type values. == Rene -----Original Message----- From: devel [mailto:[email protected]] On Behalf Of Willy Mularto Sent: dinsdag 17 september 2013 3:06 To: Alejandro Guerrieri Cc: [email protected]; Stipe Tolj Subject: Re: [PATCH] No PANIC on failing store_load() +1 It will be good to dump it to bearerbox-access log and flag it as FAILED MT and maybe add more info into it so we can analyse it. Thanks Stipe. On Sep 16, 2013, at 11:56 PM, Alejandro Guerrieri <[email protected]> wrote: > +1 this was really an annoyance IMHO > > > -- > Alejandro Guerrieri > > On Sep 16, 2013, at 11:59 AM, Stipe Tolj <[email protected]> wrote: > >> Hi list, >> >> attached is a very simple change in behavior in being more "runtime" constraining, in case a message in the spool has an invalid 'sms_type' we SHOULD NOT PANIC i.e. but rather dump an ERROR entry and try to continue. >> >> Otherwise we may enter an infinite PANIC/restart loop for cases that such messages get somehow injected to the spool. >> >> If no objections, will be committing soon. >> >> Stipe >> >> -- >> ------------------------------------------------------------------- >> Kölner Landstrasse 419 >> 40589 Düsseldorf, NRW, Germany >> >> tolj.org system architecture Kannel Software Foundation (KSF) >> http://www.tolj.org/ http://www.kannel.org/ >> >> mailto:st_{at}_tolj.org mailto:stolj_{at}_kannel.org >> ------------------------------------------------------------------- >> <store_load_no_panic.diff> >