Re: [PATCH] No PANIC on failing store_load()

Willy Mularto <[email protected]>
Newsgroups gmane.comp.mobile.kannel.devel
Message-ID <CAChGr4Ebr2WbaX=+LYAdY4=1C3x_gXh2BCiknzdMbiowmZ2jfQ@mail.gmail.com>
Thanks for your review. The other approach is to override the sms_type
value during the INSERT.
On 17 Sep 2013 21:37, "Stipe Tolj" <[email protected]> wrote:

> Am 17.09.2013 03:06, schrieb Willy Mularto:
>
>> +1
>> It will be good to dump it to bearerbox-access log and flag it as FAILED
>> MT and maybe add more info into it so we can analyse it. Thanks Stipe.
>>
>
> BTW, committed to svn trunk.
>
> Disagree here for the "FAILED SMS" access-log entry, since it is logically
> not failing. The SMSC *HAS* accepted the submit_sm PDU, since we get a
> submit_sm_resp.command_status = 0x00.
>
> Not sure, but is seems to me that this specific SMCS does not return a
> message_id *IF* the ESME hasn't requested a delivery report, and if he has
> requested then they provide the message_id. It still mis-interprets the
> spec, but at least we can handle it in the sense that the daemon doesn't
> PANIC out and keeps on running.
>
> Stipe
>
> --
> ------------------------------**------------------------------**-------
> Kölner Landstrasse 419
> 40589 Düsseldorf, NRW, Germany
>
> tolj.org system architecture      Kannel Software Foundation (KSF)
> http://www.tolj.org/              http://www.kannel.org/
>
> mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
> ------------------------------**------------------------------**-------
>
>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.