Re: [PATCH] No PANIC on failing store_load()
Alejandro Guerrieri <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <CAG8-fBkcYbsk9+WPLVjcruXrun0qPv4zB=aT-LcR8YzY4XxsZA@mail.gmail.com> |
MO tables are not impacted by the problem of having an empty column, are they? If that's the case I'd leave them with no default. On Tue, Sep 17, 2013 at 3:47 PM, Stipe Tolj <[email protected]> wrote: > Am 17.09.2013 18:56, schrieb Rene Kluwen: > > Agreed with Stipe here. >> If the users enters a different value for sms_type, it is their >> responsibility. >> >> What is covered here, is an accidental wrong value for sms_type, because >> nowhere is documented that sms_type should be set to MT (value '2') >> because >> otherwise Kannel will panic. >> >> Attached is a simple solution that will benefit everyone. Which is ready >> to >> be committed. >> > > +1 from me. What about the direction implication? Is this table only for > the MT direction? > > For an MO table we may have an other value for sms_type here. > > > Stipe > > -- > ------------------------------**------------------------------**------- > Kölner Landstrasse 419 > 40589 Düsseldorf, NRW, Germany > > tolj.org system architecture Kannel Software Foundation (KSF) > http://www.tolj.org/ http://www.kannel.org/ > > mailto:st_{at}_tolj.org mailto:stolj_{at}_kannel.org > ------------------------------**------------------------------**------- > >