Re: [Patch] Improve logging function
Alejandro Guerrieri <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <CAG8-fBmZdXdTS-cYMn5Wy14ktCgJFuRig8TyJFT0iwnKoHgbig@mail.gmail.com> |
+1 makes perfect sense On Wed, Oct 2, 2013 at 11:52 AM, Jacek Raczkiewicz < [email protected]> wrote: > Hi, > > I have been working on imrpving application that uses a lot libraries from > kannel/gwlib. > I noticed that logging function does format the string even if there is no > intention to save it to the log due to configured log level. > My improvement is that I moved the format() function inside the > conditional block which check for log level. > This really make a difference when logged string is large (in our case it > may be as big as 1MB) and that is formatted for no reason. > > Please include this fix into kannel codebase. > > Regards > Jacek Raczkiewicz >