Re: [PATCH] Optional usage of submit_sm.message_payload for large MTs

Am 03.06.2014 14:56, schrieb Alexander Malysh:
> Hi Stipe,
>
> this chunk -1:
>
> +    /* PDU allowed payload size is 64K, so change max SMS octet value */
> +    if (cfg_get_bool(&smpp->message_payload, grp, octstr_imm("message-payload")) == 1)
> +        conn->max_sms_octets = 65536;
>
> I would prefer that user set max-sms-octets in the config because this will break many installations and this is even wrong
> because if user set max-sms-octets in the config you just overwrite it here and user has no chance to change it.

ok, the last reason seems reasonable for me, I agree.

But if we don't set the max_sms_octets, then the abstraction layer will 
pre-chunk any SMS into GSM PDU length sized chunks and hence in the SMPP 
layer we can't send anything bigger then 140 octets that uses 
.message_payload. This doesn't make sense either.

So, we would need to check IF conn->max_sms_octets != default, then we 
know user has individually set an alternative value and stick to that 
value, otherwise we DO set to 64K for the sake of getting the full 
length supported of the PDU field.

Stipe

-- 
-------------------------------------------------------------------
Kölner Landstrasse 419
40589 Düsseldorf, NRW, Germany

tolj.org system architecture      Kannel Software Foundation (KSF)
http://www.tolj.org/              http://www.kannel.org/

mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
-------------------------------------------------------------------