Re: [PATCH] Optional usage of submit_sm.message_payload for large MTs

Hi,

this is very messy:

> +    if (cfg_get_bool(&smpp->message_payload, grp, octstr_imm("message-payload")) == 1 &&
> +            cfg_get_integer(&conn->max_sms_octets, grp, octstr_imm("max-sms-octets")) == -1)
> +        conn->max_sms_octets = 65536;

max-sms-octets is SMSC group option and is already set in SMSC layer for _all_ smsc modules.
I don't think we need to set 64K here because it should be set by the user explicitly because SMSCs
that I saw and that require message_payload accepted only 140 Octets.

IMHO, the user has to set both (1) use message_payload and (2) max-sms-octets depending on the
infos provided by SMSC operator.

Alex

Am 03.06.2014 um 19:58 schrieb Stipe Tolj <[email protected]>:

> ok, here we go again, with corresponding change:
> 
> +    /* If we want message_payload to be used as PDU field, and no 'max-sms-octets'
> +     * is given, then we can switch to use a max-sms-octets size of 64K to support
> +     * the full size of the message_payload field. */
> +    if (cfg_get_bool(&smpp->message_payload, grp, octstr_imm("message-payload")) == 1 &&
> +            cfg_get_integer(&conn->max_sms_octets, grp, octstr_imm("max-sms-octets")) == -1)
> +        conn->max_sms_octets = 65536;
> 
> in order to switch only to the 64K size IF no other value has been given to be respected due to user configuration.
> 
> Stipe
> 
> -- 
> -------------------------------------------------------------------
> Kölner Landstrasse 419
> 40589 Düsseldorf, NRW, Germany
> 
> tolj.org system architecture      Kannel Software Foundation (KSF)
> http://www.tolj.org/              http://www.kannel.org/
> 
> mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
> -------------------------------------------------------------------
> 
> <smpp-message-payload.v3.diff>