Re: PATCH: Fix use of uninitialized variable (mysql port) in sqlbox

Hi,

I recall that bearerbox and sqlbox use unix socket when no port was 
specified in the config. Using unix socket is usually a bit faster than 
TCP but of course the database must be installed on the same machine.
Perhaps the behaviour is different with more recent library versions and 
I'm unable to confirm that.

regards,
C.

On 09/11/2015 14:23, Vyronas Tsingaras wrote:
> sqlbox would try to connect to random ports on the mysql host if no 
> port was defined due to an uninitialized variable use.
>
> Index: sqlbox_mysql.c
> ===================================================================
> --- sqlbox_mysql.c(revision 55)
> +++ sqlbox_mysql.c(working copy)
> @@ -396,6 +396,9 @@
>      if (have_port) {
>  db_conf->mysql->port = mysql_port;
>      }
> +    else {
> +  db_conf->mysql->port = 3306;
> +    }
>      pool = dbpool_create(DBPOOL_MYSQL, db_conf, pool_size);
>      gw_assert(pool != NULL);
>
> -- 
> 	
> *Vyronas Tsingaras **| IT Department*
> 12th Km Thessaloniki - Liti, Zip.57200, Greece
> Tel.: +30.23940.20336, Fax: +30.23940.25922
> Skype id: vtsingaras.amdtelecom
> E-mail: [email protected] <mailto:[email protected]>
> www.amdtelecom.net <http://www.amdtelecom.net/> 
> <http://www.linkedin.com/company/amd-telecom-s.a.?trk=company_logo> 
> <https://www.facebook.com/pages/AMD-Telecom/282439285138965?fref=ts> 
> <https://www.twitter.com/amdtelecom>
>
>
> 	
> Please consider the environment before printing this email
>
> This e-mail message and all attachments transmitted with it are 
> confidential and are intended solely for the addressee(s). If the 
> reader of this message is not the intended recipient, you are hereby 
> notified that any reading, dissemination, distribution, copying, or 
> other use of this message or its attachment(s) is strictly prohibited.
>