RE: [PATCH] priority with sqlbox

Patch commited. Thanks for the contribution.

 

 

Van: Giulio Giovannini [mailto:[email protected]] 
Verzonden: maandag 2 mei 2016 10:43
Aan: Rene Kluwen <[email protected]>
CC: [email protected]
Onderwerp: Re: [PATCH] priority with sqlbox

 

Actually, I have it working in production and the foreign id is stored in the sent_sms table.

 

I probably don't know the code as you do, but if I removed the foreign id it was by accident. It wasn't my intention and it should not be needed to make this patch work. The priority is just another parameters added to the many other we already have in the send_sms table.

 

Almost all changes in the patch are like the one below. You can see that the priority is added just before the foreign id.

 

-                st_str(msg->sms.boxc_id), st_str(msg->sms.binfo), st_str(msg->sms.meta_data), st_str(msg->sms.foreign_id));

+                st_str(msg->sms.boxc_id), st_str(msg->sms.binfo), st_str(msg->sms.meta_data), st_num(msg->sms.priority), st_str(msg->sms.foreign_id));

 

 




--

Mobyt S.p.A.
Via Aldighieri, 10 - 44121 Ferrara - Italy
------------------------------------------
Phone :  <tel:%2B39%200532%20207296> +39 0532 207296 - Fax :  <tel:%2B39%200532%20242952> +39 0532 242952
E-mail:  <mailto:[email protected]> [email protected] - Web:  <http://www.mobyt.it/> http://www.mobyt.it

Mobyt ® - messaging services

 

2016-05-02 10:11 GMT+02:00 Rene Kluwen <[email protected] <mailto:[email protected]> >:

If you look at the patch, you’ll see that the foreign_id field is removed completely from the table and it is not stored anymore.

 

Van: Giulio Giovannini [mailto:[email protected] <mailto:[email protected]> ] 
Verzonden: maandag 2 mei 2016 9:22
Aan: Rene Kluwen <[email protected] <mailto:[email protected]> >
Onderwerp: Re: [PATCH] priority with sqlbox

 

Hello Rene,

 

I don't get what you mean. What does the 'foreign id' value refer to and why would you lose it with this patch?

 

Best regards,

Giulio




--

Mobyt S.p.A.
Via Aldighieri, 10 - 44121 Ferrara - Italy
------------------------------------------
Phone :  <tel:%2B39%200532%20207296> +39 0532 207296 - Fax :  <tel:%2B39%200532%20242952> +39 0532 242952
E-mail:  <mailto:[email protected]> [email protected] - Web:  <http://www.mobyt.it/> http://www.mobyt.it

Mobyt ® - messaging services

 

2016-04-29 18:08 GMT+02:00 Rene Kluwen <[email protected] <mailto:[email protected]> >:

Possibly useful patch. But I think it’s mainly useful for internal purposes, where you will be sure you want to sacrifice the loss of getting the foreign id value to gain access to the priority field.


So -1 from me to include this in the official repository in this form.

 

== Rene

 

Van: devel [mailto:[email protected] <mailto:[email protected]> ] Namens Giulio Giovannini
Verzonden: woensdag 27 april 2016 15:04
Aan: [email protected] <mailto:[email protected]> 
Onderwerp: [PATCH] priority with sqlbox

 

Hi all,

 

I needed to be able to pass the 'priority' parameter to the bearerbox using the sqlbox so I developed the patch in the attachement.

 

It has been working in production for a while now.

 

My setup is very easy: sqlbox is attached to bearerbox and is used to inject SMS into bearerbox with simple inserts in sqlbox MySQL send_sms table. I haven't got a smsbox attached to the sqlbox so I don't know if there might be issues with that.

 

The patch only works for MySQL.

 

Best regards,

Giulio Giovannini

--

Mobyt S.p.A.
Via Aldighieri, 10 - 44121 Ferrara - Italy
------------------------------------------
Phone :  <tel:%2B39%200532%20207296> +39 0532 207296 - Fax :  <tel:%2B39%200532%20242952> +39 0532 242952
E-mail:  <mailto:[email protected]> [email protected] - Web:  <http://www.mobyt.it/> http://www.mobyt.it

Mobyt ® - messaging services