RE: [PATCH] Memory leak in smpp_pdu.c

"Rene Kluwen" <[email protected]> Sat, 24 Sep 2016 13:55:31 +0200

Newsgroups	gmane.comp.mobile.kannel.devel
Message-ID	<[email protected]>

+1 from me.

 

Van: devel [mailto:[email protected]] Namens Donald Jackson
Verzonden: zaterdag 24 september 2016 12:00
Aan: kannel_dev_mailinglist <[email protected]>
Onderwerp: [PATCH] Memory leak in smpp_pdu.c

 

Hi all, 

 

I have been assisting with a KSMPPD implementation and couldn't figure out why the application was leaking memory.

 

After a long search I found that an SMPP client was sending the same TLV multiple times which was causing lost pointers/memory leaks.

 

I believe this would effect all Kannel derivatives (OpenSMPPBox, Commercial SMPPBox and Bearerbox) in the cases where an incorrectly implemented (or malicious?) client or gateway could be the cause of memory leaks.

 

Herewith patch to fix.

 

Thanks,

Donald