RE: [PATCH] KSMPPD (and other?) utility methods for smpp_pdu.c

"Rene Kluwen" <[email protected]> Sat, 24 Sep 2016 13:58:32 +0200

Newsgroups	gmane.comp.mobile.kannel.devel
Message-ID	<[email protected]>

Sure, but why not change KSMPPD to use smpp_pdu_pack() function without the length?

 

== Rene

 

 

Van: devel [mailto:[email protected]] Namens Donald Jackson
Verzonden: zaterdag 24 september 2016 12:07
Aan: kannel_dev_mailinglist <[email protected]>
Onderwerp: [PATCH] KSMPPD (and other?) utility methods for smpp_pdu.c

 

Hi all, 

 

Currently KSMPPD runs a patch against Kannel SVN trunk, I believe it would be better if we could just include this patch in the mainline Kannel as they don't have any negative implications.

 

Currently the smpp_pdu_unpack() function takes data without length but the smpp_pdu_pack() function provides length so these two functions are not compatible with each other.  This simple patch just allows for compatibility convenience.

 

Thanks,

Donald