RE: [PATCH] Memory leak in smpp_pdu.c

Alexander Malysh <[email protected]> Tue, 18 Oct 2016 10:18:11 +0000 (UTC)

Newsgroups	gmane.comp.mobile.kannel.devel
Message-ID	<1160330775.8881.1476785891551@ip-10-139-87-144>

Hi,

good catch! But there is a question: should we really accept such wrong PDUs or reject them?
IMHO rejecting those would be the correct behavior but I don't see in SMPP spec that case described.

Thanks,
Alexander Malysh   From: Stipe Tolj <[email protected]>
Sent: Monday, September 26, 2016 07:24 PM
To:
Cc: kannel_dev_mailinglist <[email protected]>
Subject: Re: [PATCH] Memory leak in smpp_pdu.c
Am 24.09.2016 13:55, schrieb Rene Kluwen:
> +1 from me.

yep, good catch Donald.

+1 for it.

If no objections, will commit.

--
Best Regards,
Stipe Tolj

-------------------------------------------------------------------
Düsseldorf, NRW, Germany

Kannel Foundation tolj.org system architecture
http://www.kannel.org/ http://www.tolj.org/

stolj at kannel.org st at tolj.org
-------------------------------------------------------------------