Re: Frequently failing Sysmon ping tests...

On Fri, Jul 31, 2009 at 11:53 AM, Daniel J. Luke<dluke-2DB0d86rw/[email protected]> wrote:
>
> On Jul 31, 2009, at 11:48 AM, Morgan Aldridge wrote:
>
>> I may try vsnprintf() myself if I can't get much headway any other way.
>
> If you try it and it fixes the crash for you, I'll check in the change (and
> see if I can irritate jared while he's on vacation ;-) ).

Excellent, I didn't know anyone except jared had cvs access. :)

Unfortunately,, using vsnprintf() didn't seem to do the trick:

bash-3.2$ diff lib.c.old lib.c
675c675
< 	vsprintf (buffer, fmt, ap);
---
> 	vsnprintf (buffer, sizeof(buffer), fmt, ap);

Still gives me the same crash reports.

I don't see anything wrong with fprintf() call in syslogmsg(), so I'd
assume it's something to do with the arguments being passed to
print_err() by service_test_www().

The following are the debug lines immediately before the crash
pertaining to the last test:

Aug  3 07:54:56 bento org.sysmon.sysmond[51596]: sysmond: 07:54:56
service_this:Servicing entry in queue of bento.makkintosshu.com:www
Aug  3 07:54:56 bento org.sysmon.sysmond[51596]: sysmond: 07:54:56
http.c:Got :   <TD align=right>DL Rate<TD align=right>UL Rate:
Searching for :CTCS Version 1.4.1:
Aug  3 07:54:56 bento org.sysmon.sysmond[51596]: sysmond: 07:54:56
http.c:Got :   <TD align=right>DL Total<TD align=right>UL Total:
Searching for :CTCS Version 1.4.1:
Aug  3 07:54:56 bento org.sysmon.sysmond[51596]: sysmond: 07:54:56
http.c:Got :   <TD align=right>Limit D/U</TR>: Searching for :CTCS
Version 1.4.1:
Aug  3 07:54:56 bento org.sysmon.sysmond[51596]: sysmond: 07:54:56
http.c:Got :<TR bgcolor="#ccccff"><TD colspan=5><A
HREF="/torrent/-CD0303-u0xB94F21EDF3472D60A568C8"><B>/Library/BitTorrent/Newton_Museum_.dmg_file.4006452.TPB.torrent</B></A>:
Searching for :CTCS Version 1.4.1:
Aug  3 07:54:56 bento org.sysmon.sysmond[51596]: sysmond: 07:54:56
http.c:Got :   <TD colspan=3 align=right>Sun Aug  2 02:02:29
2009</TR>: Searching for :CTCS Version 1.4.1:
Aug  3 07:54:56 bento org.sysmon.sysmond[51596]: sysmond: 07:54:56
about to abort and dump core (i think in /)

I'd assume it has to do with the following lines in the 'WWW_SENT_REQUEST' case:

    getline_tcp(here->filedes, buffer);
    times_read++;
    if (debug)
        print_err(0, "http.c:Got :%s: Searching for :%s:", buffer,
here->checkent->url_t
ext);

Could it have anything to do with 'buffer' having a length of 1024?
None of the lines in the source of the page being requested appear to
have even 255 chars, let alone 1024, but I haven't looked at
getline_tcp() to see how it determines what one line is.

Morgan Aldridge
---
[email protected]
http://www.makkintosshu.com/