Fix for CVE-2020-25648 in nss

--==-=-=
Content-Type: multipart/mixed; boundary="=-=-="

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hello,

I am trying to backport the fix for CVE-2020-25648 to nss version 3.42.1
in Debian 10, "buster".  Unfortunately, the four tests added by the fix
do not pass.

Would someone be able to take a look at the test output, please?
Perhaps the failed test does not indicate that the fix is ineffective.
As all the other tests pass, I'm not too concerned about introducing any
regressions.

I'm including the failed test output below.  My patched version of nss
is here: <https://salsa.debian.org/lts-team/packages/nss>.
More specifically, the backported patch is here:
<https://salsa.debian.org/lts-team/packages/nss/-/blob/debian/buster/debian=
/patches/CVE-2020-25648.patch>.

Thank you.

=2D-=20
Sean Whitton

--=-=-=
Content-Type: text/plain
Content-Disposition: inline; filename=CVE-2020-25648_failures.txt

[ RUN      ] TlsConnectStreamTls13.ChangeCipherSpecAfterClientHelloEmptySid
Version: TLS 1.3
server: Changing state from INIT to CONNECTING
client: Changing state from INIT to CONNECTING
client: Send Direct [6] 140303000101
tls_agent.cc:658: Failure
Expected equality of these values:
  STATE_ERROR
    Which is: ERROR
  state_
    Which is: CONNECTING
tls_agent.cc:659: Failure
Expected equality of these values:
  expected
    Which is: -12251
  error_code_
    Which is: 0
Got error code (null) expecting SSL_ERROR_RX_MALFORMED_CHANGE_CIPHER

tls_agent.cc:115: Failure
Failed
Wrong expected_sent_alert status: server
[  FAILED  ] TlsConnectStreamTls13.ChangeCipherSpecAfterClientHelloEmptySid (3 ms)
[ RUN      ] TlsConnectStreamTls13.ChangeCipherSpecAfterServerHelloEmptySid
Version: TLS 1.3
server: Changing state from INIT to CONNECTING
client: Changing state from INIT to CONNECTING
handshake drop: [32] 1b8a089d138d6e39406bf8976a32005454bc4a5b2297f721f558948f42980a63
record old: [657] 080000240022000a00140012001d00170018001901000101010201030104001c...
record new: [621] 080000240022000a00140012001d00170018001901000101010201030104001c...
server: Original packet: [774] 160303005a020000560303cce13fc9d25beeda4816ae0df6c3fcfc6b075b524d...
server: Filtered packet: [738] 160303005a020000560303cce13fc9d25beeda4816ae0df6c3fcfc6b075b524d...
server: Send Direct [6] 140303000101
tls_agent.cc:658: Failure
Expected equality of these values:
  STATE_ERROR
    Which is: ERROR
  state_
    Which is: CONNECTING
tls_agent.cc:659: Failure
Expected equality of these values:
  expected
    Which is: -12251
  error_code_
    Which is: 0
Got error code (null) expecting SSL_ERROR_RX_MALFORMED_CHANGE_CIPHER

tls_agent.cc:115: Failure
Failed
Wrong expected_sent_alert status: client
[  FAILED  ] TlsConnectStreamTls13.ChangeCipherSpecAfterServerHelloEmptySid (3 ms)
[ RUN      ] Tls13CompatTest.ChangeCipherSpecAfterClientHelloTwice
Version: TLS 1.3
server: Changing state from INIT to CONNECTING
client: Changing state from INIT to CONNECTING
client: Send Direct [6] 140303000101
client: Send Direct [6] 140303000101
tls_agent.cc:658: Failure
Expected equality of these values:
  STATE_ERROR
    Which is: ERROR
  state_
    Which is: CONNECTING
tls_agent.cc:659: Failure
Expected equality of these values:
  expected
    Which is: -12251
  error_code_
    Which is: 0
Got error code (null) expecting SSL_ERROR_RX_MALFORMED_CHANGE_CIPHER

tls_agent.cc:115: Failure
Failed
Wrong expected_sent_alert status: server
[  FAILED  ] Tls13CompatTest.ChangeCipherSpecAfterClientHelloTwice (3 ms)
[ RUN      ] Tls13CompatTest.ChangeCipherSpecAfterServerHelloTwice
Version: TLS 1.3
server: Changing state from INIT to CONNECTING
client: Changing state from INIT to CONNECTING
handshake drop: [32] 9fa4dd3997d365493264eb198d69844aa6090fdbe2d6d198df14cc020f20fd99
record old: [657] 080000240022000a00140012001d00170018001901000101010201030104001c...
record new: [621] 080000240022000a00140012001d00170018001901000101010201030104001c...
server: Original packet: [812] 160303007a0200007603031819fcfd8fd325cb2a943632a50c27846ad67629c4...
server: Filtered packet: [776] 160303007a0200007603031819fcfd8fd325cb2a943632a50c27846ad67629c4...
server: Send Direct [6] 140303000101
tls_agent.cc:658: Failure
Expected equality of these values:
  STATE_ERROR
    Which is: ERROR
  state_
    Which is: CONNECTING
tls_agent.cc:659: Failure
Expected equality of these values:
  expected
    Which is: -12251
  error_code_
    Which is: 0
Got error code (null) expecting SSL_ERROR_RX_MALFORMED_CHANGE_CIPHER

tls_agent.cc:115: Failure
Failed
Wrong expected_sent_alert status: client
[  FAILED  ] Tls13CompatTest.ChangeCipherSpecAfterServerHelloTwice (3 ms)

--=-=-=--

--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJNBAEBCgA3FiEEm5FwB64DDjbk/CSLaVt65L8GYkAFAmU70SwZHHNwd2hpdHRv
bkBzcHdoaXR0b24ubmFtZQAKCRBpW3rkvwZiQN/eEACjJk8FO0XGiMZjhaNsmpD2
FNAnQ/kfT4W11f78oby+zHlwioMGmDjRYAFYWOjIkblpifRwU+BXqBt3e5DnFaIO
pBwCH6QYy0pNhGtHbxXDhb3+vSyEXnYYD7OMAxfWeeSA8/YspCF6zeiCrTesErTY
Qj9Ei8oN7yCvualqarzbP9Luq1yebLhz6hBB+iT9O5ilLk6e/2BeYETEu7AJviP7
3HmWT9f3zFcaMIPBN8S1BMlWI7TbzhohoyaYVomu3FutX9lQOge3uLQBBc8CNjz5
U/5Ec7yrus89oxd+wtY696UbF4o9WfHN0SFn+F+/GFlJrj2fm+RzBelwrEoql9gs
yd8QXiiAJ737DfaXv9mQg6Smax9IH+1+X6b9BkUlFZEvxjc6MwaaDKKyUtTm7hai
xSyoBjUGfDV2sd8ytsu85D2OYX+m/oCl5JBC81MbC9x8IjNx3KGIPKcxoU+eSUDn
RvsOHe1DpsSFkHFeJhA0BuRJbc7QxMvJmtKHSxxip4QLeNoWhIIyiJAqGaSP1nNp
t3Kzmvx2qR+hruW3hXcrkpo9z1pBFGdOINz3tYpE1pR2pPskbwyp4sgAGX1SaJGU
Ijj3plgKfr54hcTTLTK2jeJf+wnghqiewzlv4oq/dgZjIpMds6QkIGYxciRowNLJ
AfKN7C2/P1DpRphlzeUHoA==
=etij
-----END PGP SIGNATURE-----
--==-=-=--