CI issues.

Robert Relyea <[email protected]> Thu, 14 Nov 2024 16:16:00 -0800
Newsgroups gmane.comp.mozilla.crypto
Message-ID <[email protected]>
So I'm getting ready to push some of the bug fixes we made in RHEL after 
the nss-3.101 rebase and I've found that we have test failures. After 
debugging I found that we have issues with the tools test. One of the 
fixed 
https://hg.mozilla.org/projects/nss/rev/26d04d787d02e68c7f0752c16a113b7157ac9e3e, 
(which fixed a real bug) caused our tests for fail. These were tests 
expecting to fail, but the change changed the failure code.

So 1) we shouldn't be checking things into tree when the tests are 
failing so badly, and 2) we should make sure the tests we check in don't 
introduce new failures. We have some tests on some platforms that are 
continually failing, we should figure those out, but you really should 
run all.sh on your machine just to make sure something hasn't been trashed.

There are two fixes for the current failure. The immediate fix is to 
change the expected error code. This will make the tests pass, but then 
the tests will stop actually testing the thing they are testing for. The 
second is to add an option to ignore password integrity checks, and use 
it on those tests.

I'll see how hard the latter is, but maybe for now we can change the 
expected error code and get tools green again?

Bob

-- 
You received this message because you are subscribed to the Google Groups "[email protected]" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion visit https://groups.google.com/a/mozilla.org/d/msgid/dev-tech-crypto/af701e59-e683-4eb3-b05c-5f4d7fbf953d%40redhat.com.