Re: libssldap/clientinit.c:inited not protected?

maybe, and i know it probably makes sense in your particular use case
where you fork continuously but for normal usage scenarios it never
has been a problem per se.

On 18/03/2010 10:46, Milan Jurik wrote:
> I am looking at NSS initialization in libldap and I see that Mozilla
> libldap is not protecting usage of inited variable:
>
> On the beginning it tests for inited value if 0, but value is set much
> later to 1, so several calls to ldapssl_clientauth_init() or
> ldapssl_advclientauth_init() or ldapssl_pkcs_init() in parallel can lead
> to many unnecessary ldapssl_basic_init() calls.
>
> Would it be better to use some mutex for protection of it?