Re: dom/ and content/ source reorganization
Jonas Sicking <[email protected]>
| Newsgroups | gmane.comp.mozilla.devel.dom |
|---|---|
| Message-ID | <[email protected]> |
Benjamin Smedberg wrote: > On 1/22/09 6:24 PM, Jonas Sicking wrote: >> Benjamin Smedberg wrote: >>> On 1/20/09 7:38 PM, Jonas Sicking wrote: >>> >>>>> 3) Use the following other directories: >>>> Don't really think the following deserve their own directories >>>> >>>> dom/json >>> I can merge this into dom/window >> Why dom/window? It's not window related at all. I'd say dom/base > > It is a property of the DOM window object. > >>>> dom/offline (don't feel strongly here) >>>> dom/storage (don't feel strongly here either) >>> I can merge either/both of these with dom/window >> Hmm.. why this facination with dom/window? I would have expected that it >> would only do the window objects, and maybe a couple supporting >> dom-level-0 objects like window.location and window.navigator? > > Also because it is a global property off the DOM window object. I think > dom/base should be shared code for nodes/documents or utility code. The fact that these are properties of the Window object is a function of that many moons ago the window object was chosen as the global object, it's not because they have anything to do with the window. What we could do is name the directory something like "dom/api(s)" where we put stuff like window, history, JSON, XMLHttpRequest, treewalker and nodeiterator. However I'm not convinced we need to split this from dom/base. Splitting too much is what got us to where we are now. I'd probably be fine either way I'd say. / Jonas