Re: Supporting end column on JSErrorReport

Bobby Holley <[email protected]>
Newsgroups gmane.comp.mozilla.devel.jseng
Message-ID <CAKBxTcJ3yeRuqmG-4eAEczHcfpvLW0jF503XBqP=-uiR55AZ+A@mail.gmail.com>
On that note, please keep in mine that JSErrorReporters (though not
necessarily JSErrorReports) are going away, so please don't add any new
dependencies on them for SpiderNode. The Right Way to do it is to use an
RAII guard on the embedding side around any calls where you want exceptions
to be handled, and set autoJSAPIOwnsErrorReporting everwhere.

On Wed, May 4, 2016 at 8:38 AM, Jason Orendorff <[email protected]>
wrote:

> I would just set the end column to the start column plus 1.
>
> But! This would be fairly easy to fix for SyntaxErrors. Keeping precise
> location information around for every part of a script that could possibly
> go wrong would take a ridiculous amount of memory; I doubt V8 is really all
> that specific with its runtime error messages. We're not. By comparison, if
> you're parsing a script and hit an error, noting the precise location (and
> length) of the current token is a piece of cake.
>
> -j
>
>
>
> On Wed, May 4, 2016 at 6:22 AM, Ehsan Akhgari <[email protected]>
> wrote:
>
> > Hi everyone,
> >
> > Currently JSErrorReport doesn't have the notion of the end column, which
> is
> > something that is exposed by the corresponding V8 data structure
> > (v8::Message).  Is the end column something that we can easily support?
> >
> > Thanks,
> > --
> > Ehsan
> > _______________________________________________
> > dev-tech-js-engine mailing list
> > [email protected]
> > https://lists.mozilla.org/listinfo/dev-tech-js-engine
> >
> _______________________________________________
> dev-tech-js-engine mailing list
> [email protected]
> https://lists.mozilla.org/listinfo/dev-tech-js-engine
>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.