Re: Value::isGCThing now does what you'd expect

Alex Webster <[email protected]> Wed, 28 Dec 2016 12:51:36 -0500

Newsgroups	gmane.comp.mozilla.devel.jseng.internals,gmane.comp.mozilla.devel.jseng
Message-ID	<CAJ0y37UPXdqMdUHescb--4Fao-Uxw3bkRqBUQAf1j=AjaGReQw@mail.gmail.com>

Thanks,
Tom

On Tue, Dec 27, 2016 at 4:12 AM, Jan de Mooij <[email protected]> wrote:

> Hey all,
>
> I landed a JS::Value change that might affect some embedders. JS::Value
> used to have the following methods:
>
> * isMarkable(): returned true iff the Value was a GC thing (object, string,
> symbol, private GC thing).
> * isGCThing(): returned true if isMarkable() *or NullValue*.
>
> Unsurprisingly, most callers of isGCThing actually wanted isMarkable (we
> had some DOM code for instance where we took a slower path if isGCThing()
> returned true).
>
> Bug 1325075 [0] (in Firefox/SpiderMonkey 53) fixed this footgun. Now
> there's just isGCThing and it returns true iff the Value is a GC thing. The
> isMarkable and toMarkablePointer methods are gone.
>
> Thanks,
> Jan
>
> [0] https://bugzilla.mozilla.org/show_bug.cgi?id=1325075
> _______________________________________________
> dev-tech-js-engine-internals mailing list
> dev-tech-js-engine-internals-CzyLcWPZiU5YsZ3hbOqMTti2O/[email protected]
> https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals
>