renaming XUL Box layout methods

There are a number of XUL Box layout methods that were moved to
nsIFrame.  In a previous discussion about names, we came to the
conclusion that renaming these to have "XUL" in the name would
reduce confusion, especially in cases where there is an analogous
non-XUL method also on nsIFrame.

So I propose renaming the following methods:

  bool IsBoxFrame() const
  bool IsBoxWrapped() const
  nsSize GetMinSize(nsBoxLayoutState& aBoxLayoutState)
  nsSize GetPrefSize(nsBoxLayoutState& aBoxLayoutState)
  nsSize GetMaxSize(nsBoxLayoutState& aBoxLayoutState)
  nsSize GetMinSizeForScrollArea(nsBoxLayoutState& aBoxLayoutState)
  uint32_t GetOrdinal()
  nscoord GetFlex(nsBoxLayoutState& aBoxLayoutState)
  nscoord GetBoxAscent(nsBoxLayoutState& aBoxLayoutState)
  bool IsCollapsed()
  void SetBounds(nsBoxLayoutState& aBoxLayoutState, const nsRect& aRect,
                 bool aRemoveOverflowAreas = false)
  nsresult Layout(nsBoxLayoutState& aBoxLayoutState)
  nsIFrame* GetChildBox() const
  nsIFrame* GetNextBox() const
  nsIFrame* GetParentBox() const
  nsresult GetBorderAndPadding(nsMargin& aBorderAndPadding)
  nsresult GetBorder(nsMargin& aBorder)
  nsresult GetPadding(nsMargin& aBorderAndPadding)
  nsresult GetMargin(nsMargin& aMargin)
  void SetLayoutManager(nsBoxLayout* aLayout) 
  nsBoxLayout* GetLayoutManager() 
  void SetLayoutManager(nsBoxLayout* aLayout) 
  nsBoxLayout* GetLayoutManager() 
  nsresult GetClientRect(nsRect& aContentRect)
  Valignment GetVAlign() const
  Halignment GetHAlign() const
  bool IsHorizontal() const
  bool IsNormalDirection() const
  nsresult Redraw(nsBoxLayoutState& aState)
  nsresult RelayoutChildAtOrdinal(nsBoxLayoutState& aState, nsIFrame* aChild)
  bool GetMouseThrough() const
#ifdef DEBUG_LAYOUT
  nsresult SetDebug(nsBoxLayoutState& aState, bool aDebug)
  nsresult GetDebug(bool& aDebug)
  nsresult DumpBox(FILE* out)
#endif

by inserting the word XUL in the following ways:

  IsXULBoxFrame
  IsXULBoxWrapped
  GetXULMinSize
  GetXULPrefSize
  GetXULMaxSize
  GetXULMinSizeForScrollArea
  GetXULOrdinal
  GetXULFlex
  GetXULBoxAscent
  XULIsCollapsed
  XULSetBounds
  XULLayout
  GetChildXULBox
  GetNextXULBox
  GetParentXULBox
  GetXULBorderAndPadding
  GetXULBorder
  GetXULPadding
  GetXULMargin
  SetXULLayoutManager
  GetXULLayoutManager
  SetXULLayoutManager
  GetXULLayoutManager
  GetXULClientRect
  GetXULVAlign
  GetXULHAlign
  IsXULHorizontal
  IsXULNormalDirection
  XULRedraw
  XULRelayoutChildAtOrdinal
  GetXULMouseThrough
#ifdef DEBUG_LAYOUT
  SetXULDebug
  GetXULDebug
  XULDumpBox
#endif

Does this seem reasonable?

-David

-- 
𝄞   L. David Baron                         http://dbaron.org/   𝄂
𝄢   Mozilla                          https://www.mozilla.org/   𝄂
             Before I built a wall I'd ask to know
             What I was walling in or walling out,
             And to whom I was like to give offense.
               - Robert Frost, Mending Wall (1914)

_______________________________________________
dev-tech-layout mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-tech-layout

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJS8WJYAAoJEO/hYSUPhPwhmZMQAIcgSTNiZHEgIzqmM2OUoA2Q
KBhusLwx6fz3swxF63UVh9Gyt3uuVPRUcMsx8J19ACwQur64r4rHsW40N0ozbRAj
g2XzZbagR+8704pH2U3mPMczZ8j9KJ4P1NmpIyBFk+n92KgjZDMGhHlV4s4CYV+G
uCHY0RN7TqtaHv9uWzU3DbhoYJPDV0g6ggpek9/FA/1EaYPbrD882/4zI8m93b4P
jIjU2yTO4hepz1v9qdusHSODn+yGUSgHRd5h7SGDcaPSNM/OKIiw6EmmO/fTDGPp
Jz6hKtIVTFz5/mxs7mr1LQzxBRkfwS7gXoREWVpxiBIqaZnYRO0b5iNrU8TdLrU4
Nye6VWujUmoq8BGxJW1zziftxpF81bih69E5udWbJE45rkF6DTn+RChwZ88WkMpt
/9jQ99DH7XW9qT3zd6DeDpSQCXVB5B9LLqOIYpLh39RUnIMeBYfL+nOvf8PtNRTa
C31RyHafYarPNVEL6rfSB4tgdP3ThJBMrevzkjQYw73MzPtXU6E1umKEH0FYOicI
ST0mjC3DOWfL7bvvrnaKeo3JcE1fTsQWTPESy2Q15egh94iLK/cuQ3BibASkNsiA
PSXAgG0MXXeJQvtxMWpL83cNNTE+Th3qQOiszHOo3/tpVkQQtJKedYwWuWU/52rB
viCYnNmgm+eJjo/D0uv1
=toTd
-----END PGP SIGNATURE-----